Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on Node.js global object #1776

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Don't rely on Node.js global object #1776

merged 1 commit into from
Dec 3, 2021

Conversation

jaylinski
Copy link
Member

Description

If global is used and handlebars is compiled for browser
usage without a Node.js global polyfill, handlebars
fails with a global is undefined error.

Fixes #1593


  • Please don't start pull requests for security issues. Instead, file a report at https://www.npmjs.com/advisories/report?package=handlebars
  • Maintain the existing code style
  • Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
  • Have good commit messages
  • Have tests
  • Have the typings (lib/handlebars.d.ts) updated on every API change. If you need help, updating those, please mention that in the PR description.
  • Don't significantly decrease the current code coverage (see coverage/lcov-report/index.html)
  • Currently, the 4.x-branch contains the latest version. Please target that branch in the PR.

If `global` is used and handlebars is compiled for browser
usage without a Node.js `global` polyfill, handlebars
fails with a `global is undefined` error.

Fixes #1593
@jaylinski jaylinski self-assigned this Dec 3, 2021
@jaylinski jaylinski mentioned this pull request Dec 3, 2021
8 tasks
@jaylinski jaylinski merged commit 2954e7e into 4.x Dec 3, 2021
@jaylinski jaylinski deleted the browser-compat branch December 3, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant