Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Comparsion Operation to Strict Equal #1217

Closed
wants to merge 2 commits into from

Conversation

kazikai
Copy link

@kazikai kazikai commented May 4, 2016

The "==" or "!=" operator is not strict comparison operator.
It means equality without type coercion.
so we should be avoided.

@kazikai
Copy link
Author

kazikai commented May 4, 2016

Hi, Recently I commit to Handlebars Github Proejct
But. my commit is failed in CI Build. Why do I build fails?
Thank You,

@stevenvachon
Copy link

Try changing the === null back to == null as this will catch both null and undefined.

@kazikai
Copy link
Author

kazikai commented May 9, 2016

Thank You, your response!: I understand it

@nknapp
Copy link
Collaborator

nknapp commented May 9, 2016

The failing test seems to be related to PR #1180 and not this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants