Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gemfile #331

Closed
wants to merge 5 commits into from
Closed

Update Gemfile #331

wants to merge 5 commits into from

Conversation

TheFarmingBunny
Copy link

Add jruby-pg for better support on some jruby platforms

TheFarmingBunny added 4 commits August 7, 2016 16:28
@TheFarmingBunny
Copy link
Author

No Travis failures are related to this.

@jodosha
Copy link
Member

jodosha commented Aug 10, 2016

@TheFarmingBunny Hi and thanks for this PR. The target branch is new-engine which is behind the progress that ROM did in the last month. Once, I'll update the code, I'll take care to merge this PR.

How jruby-pg is better? Thanks!

@jodosha jodosha self-assigned this Aug 10, 2016
@TheFarmingBunny
Copy link
Author

jruby-pg has slightly more features and can be simply required using require 'pg'. It also doesn't require jdbc: to be appended to database urls and, in my experience, I have run into problems while using jdbc-postgres.

10.08.2016, 11:36, "Luca Guidi" [email protected]:

@TheFarmingBunny Hi and thanks for this PR. The target branch is new-engine which is behind the progress that ROM did in the last month. Once, I'll update the code, I'll take care to merge this PR.

How jruby-pg is better? Thanks!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@jodosha
Copy link
Member

jodosha commented Aug 10, 2016

@TheFarmingBunny Thanks for the clarification. Do you if there are alternatives for MySQL and SQLite3 too?

@TheFarmingBunny
Copy link
Author

I don't know of any alternatives for them.

@TheFarmingBunny
Copy link
Author

Do we require pg 0.18? If so that might be a block according to this issue:
headius/jruby-pg#25

@jodosha
Copy link
Member

jodosha commented Aug 10, 2016

@TheFarmingBunny There is no restriction to the pg version.

@TheFarmingBunny
Copy link
Author

That's great

Fully remove jdbc-postgres dependency
@jodosha jodosha force-pushed the new-engine branch 2 times, most recently from ba56bbe to 9d048bf Compare September 2, 2016 16:06
@AlfonsoUceda
Copy link
Contributor

AlfonsoUceda commented Nov 12, 2016

@TheFarmingBunny could you close this PR and open a new one comparing to master? Thanks!

@TheFarmingBunny
Copy link
Author

Sure!

@hangingman
Copy link

I want to deploy hanami with JRuby & Heroku & Postgresql.
This feature is interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants