Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow source control of public/404,500.html via gitignore #286

Closed
wants to merge 2 commits into from

Conversation

kyleplump
Copy link
Contributor

@kyleplump kyleplump commented Jan 9, 2025

Closes #285

When generating the .gitignore file on hanami new, allow the public/404.html and public/500.html files, while keeping the rest of public/ ignored.

please let me know if you'd like to see any changes. thanks!

Kyle Plump added 2 commits January 9, 2025 17:04

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
@timriley timriley changed the title whitelist public/404,500.html in gitignore Allow source control of public/404,500.html via gitignore Jan 10, 2025
@kyleplump kyleplump closed this by deleting the head repository Feb 20, 2025
@cllns
Copy link
Member

cllns commented Feb 20, 2025

@kyleplump do you mind re-creating this PR too? :)

@kyleplump
Copy link
Contributor Author

@cllns 😔

new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated .gitignore should explicitly allow public/{404,500}.html
2 participants