You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Was this deliberate? It isn't obviously related to the other javadoc changes in that commit. If it is deliberate, it could be worth mentioning separately in the release note for the next release.
The text was updated successfully, but these errors were encountered:
Thanks for pointing that out, @cushon. I was cleaning up all warnings from the javadoc compiler. The warning was something like "default constructor with no javadoc". I can't quite remember exactly. It's probably worth reverting that particular change. I don't want to cause unnecessary breakage.
tumbarumba
added a commit
to tumbarumba/JavaHamcrest
that referenced
this issue
Nov 17, 2024
CoreMatchers, MatcherAssert, and Matchers had private contructors added
to fix javadoc warnings. Unfortunately, this can break existig users of
the classes.
Fixeshamcrest#427
The javadoc cleanup change in 21a0529 also added a few private constructors, including to
CoreMatchers
:JavaHamcrest/hamcrest/src/main/java/org/hamcrest/CoreMatchers.java
Lines 14 to 17 in 21a0529
This is a breaking change, I found at least one case of a classes extending
CoreMatchers
:https://github.com/chromium/chromium/blob/52e4ac4401a6477a9737681e27c6d01ff3ca789f/base/test/android/javatests/src/org/chromium/base/test/util/Matchers.java#L17
Was this deliberate? It isn't obviously related to the other javadoc changes in that commit. If it is deliberate, it could be worth mentioning separately in the release note for the next release.
The text was updated successfully, but these errors were encountered: