Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to not schedule a downlink for a Halter mode non-class A uplink #216

Draft
wants to merge 1 commit into
base: feat/halter-release-v3.28.0
Choose a base branch
from
Draft

Attempt to not schedule a downlink for a Halter mode non-class A uplink #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/networkserver/grpc_gsns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,13 @@
paths := ttnpb.AddFields(matched.SetPaths,
"mac_state.recent_uplinks",
)
stored.MacState.RecentUplinks = appendRecentUplink(stored.MacState.RecentUplinks, up, recentUplinkCount)

// HALTER - if this is data mode uplink (not class A, no corresponding Rx1/Rx2 window), don't schedule a downlink, do this by not adding the uplink to the recent uplinks list

Check failure on line 1039 in pkg/networkserver/grpc_gsns.go

View workflow job for this annotation

GitHub Actions / Code Quality 

line is 180 characters (lll)
const nonClassADataUplinkPort = 222
if up.Payload.GetMacPayload().FPort != nonClassADataUplinkPort {
stored.MacState.RecentUplinks = appendRecentUplink(stored.MacState.RecentUplinks, up, recentUplinkCount)
}
// HALTER - end

if matched.DataRateIndex < stored.MacState.CurrentParameters.AdrDataRateIndex {
// Device lowers TX power index before lowering data rate index according to the spec.
Expand Down Expand Up @@ -1411,6 +1417,8 @@
return nil, err
}

// AB here is where uplink is processed, probably?

ctx = events.ContextWithCorrelationID(ctx, up.CorrelationIds...)
ctx = appendUplinkCorrelationID(ctx)
up.CorrelationIds = events.CorrelationIDsFromContext(ctx)
Expand Down
Loading