This repository has been archived by the owner on Jul 24, 2023. It is now read-only.
Wrap helper_method calls in respond_to?(:helper_method) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `Monban::ControllerHelpers` depends on `#helper_method`, which is defined inside `AbstractController::Helpers`. This module is included in `ActionController::Base`, but it is not included by default in `ActionController::Metal`. So it's not available in Ruby on Rails 5.0 applications in API mode (rails-api). `#helper_method` is not essential to the functionality of the methods inside `Monban::ControllerHelpers`, so this PR wraps all `#helper_method` calls with `respond_to?(:helper_method)` checks. See rails/rails#21067 and heartcombo/devise#3732 for reference.
|
I've merged this onto master. Expect a 1.0.1 release soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Monban::ControllerHelpersdepends on#helper_method, which is defined insideAbstractController::Helpers. This module is included inActionController::Base, but it is not included by default inActionController::Metal. So it's not available in Ruby on Rails 5.0 applications in API mode (rails-api).#helper_methodis not essential to the functionality of the methods insideMonban::ControllerHelpers, so this PR wraps all#helper_methodcalls withrespond_to?(:helper_method)checks.See rails/rails#21067 and heartcombo/devise#3732 for reference.