Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: optimize s3link interfaces using index mechanisms #127

Merged
merged 8 commits into from
Apr 3, 2024
Merged

perf: optimize s3link interfaces using index mechanisms #127

merged 8 commits into from
Apr 3, 2024

Conversation

longjuan
Copy link
Member 

使用索引优化“关联S3文件”接口

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 19, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby March 19, 2024 07:36
@longjuan longjuan requested a review from guqing March 19, 2024 07:36
JohnNiang
JohnNiang reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ping @guqing

Please help us review the changes related to index machanism.

@guqing
Copy link
Member

guqing commented Mar 29, 2024

Hi @longjuan ，thanks for your efforts❤️ 晚些时候我会重新 review👍

guqing
guqing reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @longjuan , sorry for the late reply. I left some comments here

src/main/java/run/halo/s3os/S3LinkServiceImpl.java Outdated Show resolved Hide resolved
src/main/java/run/halo/s3os/S3LinkServiceImpl.java Show resolved Hide resolved
src/main/java/run/halo/s3os/S3LinkServiceImpl.java Outdated Show resolved Hide resolved
guqing
guqing approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts🔥

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
guqing
guqing reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@guqing guqing merged commit f4ec56b into halo-dev:main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing approved these changes

@JohnNiang JohnNiang JohnNiang left review comments

@ruibaby ruibaby Awaiting requested review from ruibaby

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@longjuan @guqing @JohnNiang