Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

使用 Lit Element 重构评论组件 #79

Closed
ruibaby opened this issue Feb 25, 2024 · 0 comments · Fixed by #80
Closed

使用 Lit Element 重构评论组件 #79

ruibaby opened this issue Feb 25, 2024 · 0 comments · Fixed by #80
Assignees
@ruibaby

Comments

@ruibaby
Copy link
Member

ruibaby commented Feb 25, 2024

期望能够和 https://github.com/halo-dev/plugin-search-widget 一样，使用 Lit Element 重构评论的 UI，以获得更小的体积和更好的移植性。

Ref halo-dev/plugin-search-widget#17
@ruibaby ruibaby mentioned this issue Feb 25, 2024
Merged
6 tasks
@ruibaby ruibaby self-assigned this Feb 25, 2024
@f2c-ci-robot f2c-ci-robot bot closed this as completed in #80 Mar 4, 2024
f2c-ci-robot bot pushed a commit that referenced this issue Mar 4, 2024
@ruibaby
refactor: use lit element to refactor comment component (#80)
5bc1867 
使用 [Lit](https://lit.dev/) 重写评论组件，可以获得更小的体积，并且提高可移植性，用于任何 JS 框架。

可测试插件：[plugin-comment-widget-2.0.0-SNAPSHOT.jar.zip](https://github.com/halo-dev/plugin-comment-widget/files/14477870/plugin-comment-widget-2.0.0-SNAPSHOT.jar.zip)


/kind improvement

Fixes #79 

此外，重写之后也解决了以下遗留问题：

1. Fixes  #78
2. Fixes #72
3. Fixes #56
4. Fixes #74
5. Fixes #81
6. Emoji 选择器的配色切换问题。

TODO:

- [x] 完成 Emoji 选择组件的适配
- [x] 完善基础样式（按钮、分页等）
- [x] 整理 CSS，抽取部分 CSS 规则为变量
- [x] 完善默认的暗黑样式
- [x] 完善操作提示（比如评论成功后的提示）
- [x] 完善文档

```release-note
使用 Lit Element 重构评论组件，以获得更小的体积，以及解决若干遗留问题。
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use lit element to refactor comment component ruibaby/plugin-comment-widget
1 participant
@ruibaby