Fix the problem of incorrect old data passed to watcher during updates #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Niang <[email protected]>
f2c-ci-robot
bot
added
kind/bug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4959 +/- ##
============================================
- Coverage 56.10% 56.08% -0.02%
- Complexity 3031 3032 +1
============================================
Files 524 524
Lines 17652 17663 +11
Branches 1315 1319 +4
============================================
+ Hits 9903 9906 +3
- Misses 7201 7209 +8
Partials 548 548 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
deleted the
bug/incorrect-old-data-for-watcher-while-updating
branch
ruibaby
pushed a commit
to ruibaby/halo
that referenced
this pull request
Nov 30, 2023
halo-dev#4959) #### What type of PR is this? /kind bug /area core /milestone 2.11.0 #### What this PR does / why we need it: This PR resolves the problem of incorrect old data passed to watcher during updates. As shown in the following line, the old value should be `old` instead of `extension` from outside. https://github.com/halo-dev/halo/blob/7a84f553005b2d8047ccdb0acf473693384a7b51/application/src/main/java/run/halo/app/extension/ReactiveExtensionClientImpl.java#L172 #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area core
/milestone 2.11.0
What this PR does / why we need it:
This PR resolves the problem of incorrect old data passed to watcher during updates. As shown in the following line, the old value should be
oldinstead ofextensionfrom outside.halo/application/src/main/java/run/halo/app/extension/ReactiveExtensionClientImpl.java
Line 172 in 7a84f55
Does this PR introduce a user-facing change?