Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade springboot to 2.5.11 #1792

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

guqing
Copy link
Member

@guqing guqing commented Mar 30, 2022

What this PR does?

升级springboot到2.5.11以解决 CVE-2022-22950: Spring Expression DoS Vulnerability

引入了 https://plugins.gradle.org/m2/ 仓库地址,因为升级springboot到2.5.11使用原有aliyun gradle plugin 仓库会报错,该仓库不存在2.5.11

Could not find spring-boot-buildpack-platform-2.5.11.jar (org.springframework.boot:spring-boot-buildpack-platform:2.5.11).
Searched in the following locations:
https://maven.aliyun.com/repository/gradle-plugin/org/springframework/boot/spring-boot-buildpack-platform/2.5.11/spring-boot-buildpack-platform-2.5.11.jar

https://developer.aliyun.com/mvn/search 确认也确实没有

Why we need it?

修复 https://spring.io/blog/2022/03/28/cve-report-published-for-spring-framework

/area core
/cc @halo-dev/sig-halo

@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Mar 30, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 30, 2022

@guqing: The label(s) kind/vulnerability cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does?

升级springboot到2.5.11以解决 CVE-2022-22950: Spring Expression DoS Vulnerability

引入了 https://plugins.gradle.org/m2/ 仓库地址,因为升级springboot到2.5.11使用原有aliyun gradle plugin 仓库会报错,该仓库不存在2.5.11

Could not find spring-boot-buildpack-platform-2.5.11.jar (org.springframework.boot:spring-boot-buildpack-platform:2.5.11).
Searched in the following locations:
https://maven.aliyun.com/repository/gradle-plugin/org/springframework/boot/spring-boot-buildpack-platform/2.5.11/spring-boot-buildpack-platform-2.5.11.jar

https://developer.aliyun.com/mvn/search 确认也确实没有

Why we need it?

修复 https://spring.io/blog/2022/03/28/cve-report-published-for-spring-framework

/area core
/kind vulnerability
/cc @halo-dev/sig-halo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@guqing
Copy link
Member Author

guqing commented Mar 30, 2022

/vulnerability

@guqing guqing added the vulnerability Vulnerability label Mar 30, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby
Copy link
Member

ruibaby commented Mar 30, 2022

/close

@ruibaby
Copy link
Member

ruibaby commented Mar 30, 2022

/reopen

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 30, 2022

@ruibaby: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot closed this Mar 30, 2022
@f2c-ci-robot f2c-ci-robot bot reopened this Mar 30, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 30, 2022

@ruibaby: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby closed this Mar 30, 2022
@ruibaby ruibaby reopened this Mar 30, 2022
@ruibaby ruibaby merged commit 1d25a58 into halo-dev:master Mar 30, 2022
@guqing guqing deleted the bugfix/spring-0day branch April 15, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core lgtm Indicates that a PR is ready to be merged. vulnerability Vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants