Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add comment assembler for theme render #1729

Merged
merged 4 commits into from
Mar 9, 2022

Conversation

guqing
Copy link
Member

@guqing guqing commented Mar 9, 2022

What this PR does?

针对前台主题渲染或api提供评论数据组装器并对敏感字段脱敏

Why we need it?

Fix #1721

@guqing guqing added the kind/bug Categorizes issue or PR as related to a bug. label Mar 9, 2022
@guqing guqing added this to the 1.5.x milestone Mar 9, 2022
@guqing guqing requested review from JohnNiang and ruibaby March 9, 2022 07:06
@guqing guqing self-assigned this Mar 9, 2022
@guqing guqing marked this pull request as draft March 9, 2022 08:48
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruibaby ruibaby marked this pull request as ready for review March 9, 2022 09:28
@JohnNiang JohnNiang merged commit d0ca7bd into halo-dev:master Mar 9, 2022
winar-jin pushed a commit to winar-jin/halo that referenced this pull request Mar 24, 2022
* feat: Add comment assembler for theme render

* fix: code style

* fix: page converter

* refactor: clear sensitive field value
@guqing guqing deleted the bugfix/1721 branch April 15, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

任意用户可查看任意评论者信息
3 participants