Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

保存设置之后会恢复至默认主题earth #3673

Closed
jkjoy opened this issue Apr 3, 2023 · 8 comments · Fixed by #3691
Closed

保存设置之后会恢复至默认主题earth #3673

jkjoy opened this issue Apr 3, 2023 · 8 comments · Fixed by #3691
Assignees
@ruibaby
Labels
area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug.
Milestone
2.5.0

Comments

@jkjoy
Copy link

jkjoy commented Apr 3, 2023

是什么版本出现了此问题？

2.4

使用的什么数据库？

H2

使用的哪种方式部署？

Docker

在线站点地址

https://blog.dasbid.com

发生了什么？

保存设置之后会恢复至默认主题earth

相关日志输出

No response

附加信息

No response
@ruibaby
Copy link
Member

ruibaby commented Apr 3, 2023

根据你的描述无法判断具体是什么问题，建议提供详细复现步骤。

/triage needs-information

@f2c-ci-robot f2c-ci-robot bot added the triage/needs-information Indicates an issue needs more information in order to work on it. label Apr 3, 2023
@jkjoy
Copy link
Author

jkjoy commented Apr 4, 2023

image
image
我已经删除了earth就提示这个
image

@jkjoy
Copy link
Author

jkjoy commented Apr 4, 2023

只要点击设置，确定，就会自动切换到earth主题。

@ruibaby
Copy link
Member

ruibaby commented Apr 4, 2023

可以复现，但这个应该是预期行为。theme-earth 目前是我们的默认主题，如果你正在使用的主题被删除，会恢复激活主题为 theme-earth。

@ruibaby
Copy link
Member

ruibaby commented Apr 4, 2023

/kind support

@f2c-ci-robot f2c-ci-robot bot added the kind/support Categorizes issue or PR as a support question. label Apr 4, 2023
@jkjoy
Copy link
Author

jkjoy commented Apr 4, 2023

我使用的事第三方主题
image
但是每次设置完成保存，主题就会恢复成默认主题。所使用的主题并没有删除。

@jkjoy
Copy link
Author

jkjoy commented Apr 4, 2023

可能是我表述让你产生了歧义。
我描述的问题只是保存设置，主题会恢复成默认主题这个bug。
由于我删除了默认主题所以才产生了如上的界面。
如果没有删除默认的情况下是保存设置之后就恢复成为了默认主题的状态。

@ruibaby
Copy link
Member

ruibaby commented Apr 4, 2023

嗯，我这边复现了。

/kind bug
/area console

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. area/console Issues or PRs related to the Halo Console labels Apr 4, 2023
@ruibaby ruibaby added kind/bug Categorizes issue or PR as related to a bug. area/console Issues or PRs related to the Halo Console and removed kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it. area/console Issues or PRs related to the Halo Console kind/support Categorizes issue or PR as a support question. labels Apr 4, 2023
@ruibaby ruibaby self-assigned this Apr 4, 2023
@ruibaby ruibaby mentioned this issue Apr 4, 2023
Merged
@ruibaby ruibaby added this to the 2.5.x milestone Apr 4, 2023
f2c-ci-robot bot pushed a commit that referenced this issue Apr 5, 2023
@ruibaby
fix: lost the activated theme settings when saving the system settings (
9b8cec4 
#3691)

#### What type of PR is this?

/kind bug
/area console
/milestone 2.5.x

#### What this PR does / why we need it:

修复保存系统设置之后，启用主题的设置丢失，恢复为了默认主题。原因是因为在 #3606 中使用了新的 useSettingFormConvert 方法，但这个方法未考虑到某些 ConfigMap 的分组并未在表单中定义，也就是数据转换方法是以表单的定义为基准，所以丢失了 `theme.active` 设置。

#### Which issue(s) this PR fixes:

Fixes #3673 

#### Special notes for your reviewer:

测试方式：

1. 安装若干主题并启用。
2. 然后去系统设置修改任意数据并保存。
3. 检查主题是否被修改为默认主题。

#### Does this PR introduce a user-facing change?

```release-note
修复保存系统设置之后导致激活主题的设置值丢失，恢复为了默认主题的问题。
```
@ruibaby ruibaby mentioned this issue Apr 7, 2023
Closed
@ruibaby ruibaby modified the milestones: 2.5.x, 2.5.0 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

fix: lost the activated theme settings when saving the system settings ruibaby/halo
2 participants
@ruibaby @jkjoy