Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

refactor: remove encodeURI handling of attachment paths. #568

Merged
merged 1 commit into from
May 18, 2022
Merged

refactor: remove encodeURI handling of attachment paths. #568

merged 1 commit into from
May 18, 2022

Conversation

FanZeros
Copy link

@FanZeros FanZeros commented May 15, 2022 •
edited by ruibaby
Loading

halo-dev/halo#1874 后端对链接进行encodeURI，前端去除
避免特殊字符的错误

None

fixes halo-dev/halo#1899
fixes halo-dev/halo#1918

@auto-assign auto-assign bot requested review from guqing, JohnNiang, LIlGG and ruibaby May 15, 2022 13:41
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 15, 2022

@FanZeros: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CLAassistant
Copy link

CLAassistant commented May 15, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 15, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ruibaby after the PR has been reviewed.
You can assign the PR to them by writing /assign @ruibaby in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FanZeros FanZeros mentioned this pull request May 15, 2022
Merged
@ruibaby
Copy link
Member

ruibaby commented May 15, 2022

/hold
/milestone 1.5.x
/kind bug

等待 halo-dev/halo#1874 合并。

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. labels May 15, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 1.5.x milestone May 15, 2022
@ruibaby
Copy link
Member

ruibaby commented May 16, 2022

/retitle refactor: disable encodeURI handling of attachment paths.

@f2c-ci-robot f2c-ci-robot bot changed the title 去除前端的encodeURI refactor: disable encodeURI handling of attachment paths. May 16, 2022
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 16, 2022
@ruibaby ruibaby changed the title refactor: disable encodeURI handling of attachment paths. refactor: remove encodeURI handling of attachment paths. May 16, 2022
@ruibaby
Copy link
Member

ruibaby commented May 17, 2022

/unhold
/cc @halo-dev/sig-halo-admin

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2022
JohnNiang
JohnNiang approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

Thank @FanZeros for contribution!

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ruibaby
ruibaby reviewed May 18, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 2e3959b into halo-dev:master May 18, 2022
@ruibaby
Copy link
Member

ruibaby commented May 18, 2022

/cherrypick release-1.5

@halo-dev-bot halo-dev-bot mentioned this pull request May 18, 2022
Merged
@halo-dev-bot
Copy link

@ruibaby: new pull request created: #570

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FanZeros FanZeros mentioned this pull request May 20, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
1.5.x
5 participants
@FanZeros @CLAassistant @ruibaby @halo-dev-bot @JohnNiang