Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

refactor: target comment modal #463

Merged
merged 6 commits into from
Feb 24, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 24, 2022

before:

image

after:

image

@ruibaby ruibaby marked this pull request as draft February 24, 2022 04:52
@ruibaby ruibaby marked this pull request as ready for review February 24, 2022 05:52
@ruibaby ruibaby requested review from guqing and JohnNiang February 24, 2022 05:53
@ruibaby ruibaby self-assigned this Feb 24, 2022
@ruibaby ruibaby added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 24, 2022
@ruibaby ruibaby added this to the 1.5.x milestone Feb 24, 2022
@ruibaby ruibaby changed the title WIP: Refactor/target comment modal refactor: target comment modal Feb 24, 2022
@ruibaby
Copy link
Member Author

ruibaby commented Feb 24, 2022

/cc @halo-dev/sig-halo-admin

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnNiang JohnNiang merged commit 8c071ae into halo-dev:master Feb 24, 2022
@ruibaby ruibaby deleted the refactor/target-comment-modal branch February 24, 2022 07:17
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
* refactor: target comment list modal

* feat: support create comment

* refactor: modal title

* feat: support switch target

* feat: support publish and reply
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants