This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
refactor: theme setting page #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ruibaby
commented
Nov 26, 2021
•
ruibaby
commented
- 提供主题设置的路由和菜单。从菜单进入主题设置默认加载当前激活主题。
- 取消抽屉式的主题设置界面。
- 提供主题的基本信息展示。
ruibaby
added
the
kind/feature
ruibaby
force-pushed
the
refactor/theme-setting-page
branch
from
7a09078 to
588ae7a
Compare
Signed-off-by: Ryan Wang <[email protected]>
ruibaby
force-pushed
the
refactor/theme-setting-page
branch
from
588ae7a to
cfc012d
Compare
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
|
关于tab要不要放到最后去 |
|
sdk升级一下 不然保存主题这个设置的功能不生效就不方便验证参数是否正确 |
可以，但考虑到当主题的 tab 很多的话，这个 tab 会被隐藏。 |
等我研究一下 js-sdk 的发版。 |
Merged
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
* refactor: theme setting page Signed-off-by: Ryan Wang <[email protected]> * feat: add theme descriptions Signed-off-by: Ryan Wang <[email protected]> * refactor: local upgrade component Signed-off-by: Ryan Wang <[email protected]> * refactor: theme descriptions Signed-off-by: Ryan Wang <[email protected]> * chore: bump admin-api deps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.