Updates dice to use CommandModule #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrct
requested changes
Oct 30, 2019
| if len(rolls) == 0: | ||
| self.reply(msg, body="You make a motion as if to roll some dice, but as you open your hands to throw them, only air escapes.") | ||
| return | ||
| def roll_(self, string, msg=None): |
There was a problem hiding this comment.
This naming scheme is potentially confusing, having a function called _roll and another called roll_. Maybe roll_cmd for the second? I can be convinced otherwise though.
| coarse = msg.body.strip().split(" ") | ||
| cmd = coarse[0] | ||
| rolls = list(filter( lambda x: re.match(die_re, x), coarse[1:] )) | ||
| def _err(self): |
There was a problem hiding this comment.
I think _err for this function name is too generic, as there is at least one other error case when the number of sides is 0
There was a problem hiding this comment.
probably makes more sense to make this a string constant anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses halibot-extra/Meta#3
Updates to use CommandModule, also made some other modifications:
This is no longer doing the list(filter(lambda))) that was being done before, as the internal _roll() function is checking the regex as the arguments are iterated over. I think the biggest change would mean now we would print an error message for each argument that is incorrect, instead of just ignoring it. So:
!roll 1d6 x"will produce
4/6 = 4You make a motion...Of course we're not doing that nice OLOP anymore, which does nicely filter the list initially, but we're not rechecking the regex. Let me know if this makes sense or not.