Webpack 4 #242
Merged
Webpack 4 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pruett
reviewed
Mar 22, 2018
package.json
Outdated
| "fs-extra": "^5.0.0", | ||
| "html-webpack-plugin": "^2.30.1", | ||
| "html-webpack-plugin": "^3.0.7cd tem ", |
|
@pruett thanks for pointing out! Fixed 👍 |
| // if (process.env.NODE_ENV === 'production') { ... }. See `./env.js`. | ||
| // It is absolutely essential that NODE_ENV was set to production here. | ||
| // Otherwise React will be compiled in the very slow development mode. | ||
| new webpack.DefinePlugin(env.stringified), |
There was a problem hiding this comment.
new webpack.DefinePlugin(env.stringified), is added twice
|
since facebook/create-react-app#4077 is merged now. |
|
None of the dependencies were released to NPM, the progress can be tracked here facebook/create-react-app#3815 |
|
Create Elm App with Webpack 4 is available at Please let me know if you are experiencing any issues! |
…ing it on precommit):
… to support webpack@4.#
Upgraded Webpack loaders and fs-extra BREAKING CHANGE: react-dev-utils is incompatible with the old one, therefore it is containing a potential breaking change.
Remove the tests for Node 4 and 6 BREAKING CHANGE: Node 4 and 6 are no longer supported.
BREAKING CHANGE: Expected engine major version upgrade
…tting for vendor stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Webpack 4 support.
CLI
yarn.lockDev
Dependencies: facebook/create-react-app#4077
While it is possible to update the InterpolateHtmlPlugin and use a temporary replacement, I think it makes sense to wait for CRA release and release CEA with all the updates.
Closes #241