Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added FlairRichText on SubmissionData to better support emojis from reddit #89

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Lurchfresser
Copy link

No description provided.

Copy link
Collaborator

@beanpuppy beanpuppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lurchfresser just ran the CI tests but they are failing. I think all you need to do is add the #[maybe_async::maybe_async] macro to the link_flairs function you added. Also it would be great if you ran cargo fmt on the PR as well.

@Lurchfresser
Copy link
Author

@beanpuppy Thank you for the reply. I am currently sick, but will do that, as soon as I get well again. Also I saw in the other PR, that you have no longer interest in maintaining this library. I want to exentend this library a bit (f.e. supporting the more type of the r/comments/article endpoint) so I can use it for a side project, but I lack the experience in rust and open source libraries.
Would it be possible if you could give me feedback on future PRs or maybe a bit of mentoring?

@beanpuppy
Copy link
Collaborator

Sure, I have no problems with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants