introduce structure for errors #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think How about In either case, thinking a little more about the interface, it may be better to revert this pull request once. |
|
paranoidhttp blocks not only internal IPs (like 6to4): https://github.com/hakobe/paranoidhttp/blob/master/client.go#L171-L174 |
Songmu
added a commit
that referenced
this pull request
Mar 30, 2019
## [v0.1.0](6495e87...v0.1.0) (2019-03-31) * adjust releng files [#11](#11) ([Songmu](https://github.com/Songmu)) * Revert "introduce structure for errors" [#8](#8) ([hakobe](https://github.com/hakobe)) * introduce structure for errors [#7](#7) ([astj](https://github.com/astj)) * Remove resolved issues from readme. [#6](#6) ([shogo82148](https://github.com/shogo82148)) * fix errors in IPv6 environment. [#5](#5) ([shogo82148](https://github.com/shogo82148)) * [incompatible] Support context more on Go 1.8 [#4](#4) ([Songmu](https://github.com/Songmu)) * support DialContext for go 1.7 [#3](#3) ([Songmu](https://github.com/Songmu)) * define mustParseCIDR and refactor [#2](#2) ([Songmu](https://github.com/Songmu)) * To prevent TOCTOU attacks, use checked IP addr directly for connections [#1](#1) ([hakobe](https://github.com/hakobe))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By introducing those structures, caller can detect for which reason the dialer returned an error.