Use droplet ID for node names in DO

docs/releases/1.29-NOTES.md

@@ -14,7 +14,7 @@ This is a document to gather the release notes prior to the release.
 
 ## DigitalOcean
 
-* Node names have changed from the droplet's private IP to the droplet hostname
+* Node names have changed from the droplet's private IP to the droplet's ID
 
 # Breaking changes
 

upup/pkg/fi/cloudup/do/verifier.go

@@ -103,7 +103,7 @@ func (o digitalOceanVerifier) VerifyToken(ctx context.Context, rawRequest *http.
 	}
 
 	result := &bootstrap.VerifyResult{
-		NodeName:          droplet.Name,
+		NodeName:          strconv.Itoa(droplet.ID),
 		CertificateNames:  addresses,
 		ChallengeEndpoint: challengeEndpoints[0],
 	}

upup/pkg/fi/nodeup/command.go

@@ -460,14 +460,14 @@ func evaluateHostnameOverride(cloudProvider api.CloudProviderID) (string, error)
 		bareHostname := strings.Split(fullyQualified, ".")[0]
 		return bareHostname, nil
 	case api.CloudProviderDO:
-		vBytes, err := vfs.Context.ReadFile("metadata://digitalocean/hostname")
+		vBytes, err := vfs.Context.ReadFile("metadata://digitalocean/id")
 		if err != nil {
-			return "", fmt.Errorf("error reading droplet hostname from DigitalOcean metadata: %v", err)
+			return "", fmt.Errorf("error reading droplet ID from DigitalOcean metadata: %v", err)
 		}
 
 		hostname := string(vBytes)
 		if hostname == "" {
-			return "", errors.New("hostname for digitalocean droplet was empty")
+			return "", errors.New("id for digitalocean droplet was empty")
 		}
 
 		return hostname, nil