Support for notes within markdown #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't been able to get this working, can you add an example to https://github.com/hakimel/reveal.js/blob/master/plugin/markdown/example.html as part of the PR? |
| @@ -55,7 +55,7 @@ This is based on [data-markdown](https://gist.github.com/1343518) from [Paul Iri | |||
| You can write your content as a separate file and have reveal.js load it at runtime. Note the separator arguments which determine how slides are delimited in the external file. | |||
|
|
|||
| ```html | |||
| <section data-markdown="example.md" data-separator="^\n\n\n" data-vertical="^\n\n"></section> | |||
| <section data-markdown="example.md" data-separator="^\n\n\n" data-vertical="^\n\n" data-notes="^[[["></section> | |||
There was a problem hiding this comment.
I think the [ characters need to be escaped: ^\[\[\[.
|
Was able to get this working now. It has been merged into the dev branch and will be released as part of reveal.js 2.5.0. Thanks @adamhepton ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new attribute when using markdown,
data-notes, which means anything between that selector and either thedata-separatorordata-verticalselectors is parsed into an<aside class=notes>.