fix: windows unit test fix #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for windows line ending difference caused failure now simple.md content mirror deck1
|
Thanks for the PR—I wasn't aware 0.0.0.0 doesn't working in Windows. There shouldn't be any issues switching to localhost but if anyone notices anything let me know. The changes you made to the markdown test caused them to break in macOS so I've rolled that back for the time being. |
shogunsea
pushed a commit
to shogunsea/reveal.js
that referenced
this pull request
Oct 24, 2021
shogunsea
added a commit
to shogunsea/reveal.js
that referenced
this pull request
Oct 24, 2021
* 'master' of github.com:shogunsea/reveal.js: revert changes to md test hakimel#3027 fix: deck 2 horizontal separator chore: lock update fix: host fix for windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3025