Update to README.md for PDF printing #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakimel
added a commit
that referenced
this pull request
Feb 14, 2017
|
Thanks! Merged with a couple of tweaks: https://github.com/hakimel/reveal.js/blob/master/README.md#pdf-export |
benswift
added a commit
to benswift/reveal.js
that referenced
this pull request
Apr 4, 2017
* hakimel-gh/master: new phantom pdf export script that works with 3.4.0 hakimel#1815 updated pdf docs update readme re: pdf exports hakimel#1823 Update README.md to include block for pdf printing Update README.md 3.4.1 adjust pdf margins instead of heights to fix hakimel#1804 additional fix for empty pages in pdf exports hakimel#1804 fix empty pages in pdf exports (closes hakimel#1804) correct grunt option usage For a fragment: allow to show a separate note defined in it
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
Update to README.md for PDF printing
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that when trying to print to PDF, there was a block of code missing from the HTML, this block is necessary for the PDF layout to be rendered properly and I didn't see it anywhere in the README so I added it in.