Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to change slide background color for full presentation mode #1386

Closed
tomjoht opened this issue Oct 6, 2015 · 9 comments
Closed

How to change slide background color for full presentation mode #1386

tomjoht opened this issue Oct 6, 2015 · 9 comments
Labels

Comments

@tomjoht
Copy link

tomjoht commented Oct 6, 2015

When I have a theme configured (such as beige.css) and I press "F" to switch to full screen presentation mode, the slide background changes to black. How can I prevent the slide background color changing away from beige to black?

The only workaround I've found is to add a data-background property to each section element:

<section data-background="#f7f2d3">

Surely there's a master setting somewhere that controls the background color when the slides are in F mode, right?

@tomjoht tomjoht changed the title Change slide background in full presentation mode How to change slide background color for full presentation mode Oct 6, 2015
@hakimel
Copy link
Owner

hakimel commented Oct 6, 2015

This was a bug – the background in fullscreen mode should automatically match the theme.

Just added a fix for this and confirmed that it's working in Chrome OS X.

@hakimel hakimel closed this as completed Oct 6, 2015
@tomjoht
Copy link
Author

tomjoht commented Oct 6, 2015

Awesome. Works great! Thanks for fixing it quickly.

@CyberShadow
Copy link

CyberShadow commented May 2, 2016

@hakimel This bug seems to be back in master. With a fresh checkout, replacing black.css in index.html with white.css, then going full-screen, causes the background to become black.

Edit: seems to happen only in Firefox Developer Edition?

Weirdly enough, this made it go away:

html { background-color: red !important; }

I see no red, though.

@kathrynwp
Copy link

Hi @hakimel - like @CyberShadow, I'm getting a black background in full-screen mode in Firefox 47.0, even though the background is white (as it should be) when not in full-screen mode.

This was not happening in Firefox 46.x.

Adding this fixes the issue, returning the full-screen background to white.

html { 
  background-color: #fff !important; 
}

The issue is not present in Chrome 51.0.2704.84 or Safari 9.1.1.

@ranr01
Copy link

ranr01 commented Jun 13, 2016

same here on firefox 47...

@dkalpakchi
Copy link

same here for firefox 47.0
in dev console it gives the following warning: "Prefixed Fullscreen API is deprecated. Please use unprefixed API for fullscreen. For more help https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API"

@hakimel
Copy link
Owner

hakimel commented Jun 20, 2016

Just pushed a fix for this to the dev branch so all theme backgrounds will display correctly in fullscreen mode.

Fullscreen ancestor selectors were moved from core reveal.scss to the theme template theme.scss. Check out the commit for a full diff: b7e0d9b

hakimel added a commit that referenced this issue Jun 21, 2016
hbrysiewicz pushed a commit to hbrysiewicz/reveal.js that referenced this issue Oct 7, 2016
hbrysiewicz pushed a commit to hbrysiewicz/reveal.js that referenced this issue Oct 7, 2016
benabraham pushed a commit to benabraham/reveal.js that referenced this issue Nov 12, 2016
KroArtem pushed a commit to KroArtem/UltraSparcT2Plus that referenced this issue Nov 21, 2016
KroArtem pushed a commit to KroArtem/UltraSparcT2Plus that referenced this issue Nov 21, 2016
SteveDesmond-ca pushed a commit to SteveDesmond-ca/presentations that referenced this issue Apr 19, 2017
SteveDesmond-ca pushed a commit to SteveDesmond-ca/presentations that referenced this issue Apr 19, 2017
SteveDesmond-ca pushed a commit to SteveDesmond-ca/presentations that referenced this issue Apr 19, 2017
@QHose
Copy link

QHose commented Sep 15, 2017

I have this issue again with a fresh pull...

@bnjmnt4n bnjmnt4n added the bug label Jan 22, 2018
@bnjmnt4n
Copy link
Collaborator

bnjmnt4n commented Jan 22, 2018

Can't seem to replicate this issue anymore with latest Firefox 57, should be fixed already.

derheap pushed a commit to derheap/reveal.js that referenced this issue Feb 22, 2018
derheap pushed a commit to derheap/reveal.js that referenced this issue Feb 22, 2018
derheap pushed a commit to derheap/reveal.js that referenced this issue Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants