-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
masking and dataset list #343
Conversation
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
=======================================
Coverage 94.75% 94.75%
=======================================
Files 9 9
Lines 3944 3944
Branches 859 859
=======================================
Hits 3737 3737
Misses 131 131
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
* compute masks * update dataset list, showing ECCO * add datasets * move order of datasets * . * restore all * restore all * compute when first masking * remove ECCO * include ECCO on dataset list * first perssit then compute * improved description of ECCO and daily ECCO --------- Co-authored-by: Miguel Jimenez <[email protected]>
This PR adresses issues #341 and #342 by:
mask.compute()
explicitly .