Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize ExpressionsEditor #306

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Localize ExpressionsEditor #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Assets/Hai/ComboGesture/Scripts/Editor/EditorUI/CgeLocale.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ namespace Hai.ComboGesture.Scripts.Editor.EditorUI
{
public class CgeLocale
{
internal static string CORE_Switch = "Switch language (English / 日本語)";
internal static string CORE_Inaccuracy = "一部の翻訳は正確ではありません。cge.jp.jsonを編集することができます。";
private static string CGE_Documentation_URL => LocalizeOrElse("CGE_Documentation_URL", CgeLocaleDefaults.CGE_Documentation_URL);
private static string CGE_PermutationsDocumentation_URL => LocalizeOrElse("CGE_PermutationsDocumentation_URL", CgeLocaleDefaults.CGE_PermutationsDocumentation_URL);
private static string CGE_IntegratorDocumentation_URL => LocalizeOrElse("CGE_IntegratorDocumentation_URL", CgeLocaleDefaults.CGE_IntegratorDocumentation_URL);
Expand Down
12 changes: 2 additions & 10 deletions Assets/Hai/ComboGesture/Scripts/Editor/EditorUI/ComboGestureActivityEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,19 +229,11 @@ public override void OnInspectorGUI()
{
serializedObject.Update();

if (GUILayout.Button("Switch language (English / 日本語)"))
if (GUILayout.Button(CgeLocale.CORE_Switch))
{
CgeLocalization.CycleLocale();
}

if (CgeLocalization.IsEnglishLocaleActive())
{
EditorGUILayout.LabelField("");
}
else
{
EditorGUILayout.LabelField("一部の翻訳は正確ではありません。cge.jp.jsonを編集することができます。");
}
EditorGUILayout.LabelField(CgeLocalization.IsEnglishLocaleActive() ? "" : CgeLocale.CORE_Inaccuracy);

_foldoutHelp = EditorGUILayout.Foldout(_foldoutHelp, new GUIContent("Help", _guideIcon32));
if (_foldoutHelp)
Expand Down
12 changes: 2 additions & 10 deletions Assets/Hai/ComboGesture/Scripts/Editor/EditorUI/ComboGestureCompilerEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,19 +142,11 @@ public override void OnInspectorGUI()
serializedObject.Update();
var italic = new GUIStyle(GUI.skin.label) {fontStyle = FontStyle.Italic};

if (GUILayout.Button("Switch language (English / 日本語)"))
if (GUILayout.Button(CgeLocale.CORE_Switch))
{
CgeLocalization.CycleLocale();
}

if (CgeLocalization.IsEnglishLocaleActive())
{
EditorGUILayout.LabelField("");
}
else
{
EditorGUILayout.LabelField("一部の翻訳は正確ではありません。cge.jp.jsonを編集することができます。");
}
EditorGUILayout.LabelField(CgeLocalization.IsEnglishLocaleActive() ? "" : CgeLocale.CORE_Inaccuracy);

if (GUILayout.Button(new GUIContent(CgeLocale.CGEC_Documentation_and_tutorials, _guideIcon32)))
{
Expand Down
12 changes: 2 additions & 10 deletions Assets/Hai/ComboGesture/Scripts/Editor/EditorUI/ComboGestureIntegratorEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,11 @@ public override void OnInspectorGUI()
{
serializedObject.Update();

if (GUILayout.Button("Switch language (English / 日本語)"))
if (GUILayout.Button(CgeLocale.CORE_Switch))
{
CgeLocalization.CycleLocale();
}

if (CgeLocalization.IsEnglishLocaleActive())
{
EditorGUILayout.LabelField("");
}
else
{
EditorGUILayout.LabelField("一部の翻訳は正確ではありません。cge.jp.jsonを編集することができます。");
}
EditorGUILayout.LabelField(CgeLocalization.IsEnglishLocaleActive() ? "" : CgeLocale.CORE_Inaccuracy);

if (GUILayout.Button(new GUIContent(CgeLocale.CGEI_Documentation, _guideIcon32)))
{
Expand Down
12 changes: 2 additions & 10 deletions Assets/Hai/ComboGesture/Scripts/Editor/EditorUI/ComboGesturePuppetEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,19 +84,11 @@ public override void OnInspectorGUI()
mainTree.objectReferenceValue = null;
}

if (GUILayout.Button("Switch language (English / 日本語)"))
if (GUILayout.Button(CgeLocale.CORE_Switch))
{
CgeLocalization.CycleLocale();
}

if (CgeLocalization.IsEnglishLocaleActive())
{
EditorGUILayout.LabelField("");
}
else
{
EditorGUILayout.LabelField("一部の翻訳は正確ではありません。cge.jp.jsonを編集することができます。");
}
EditorGUILayout.LabelField(CgeLocalization.IsEnglishLocaleActive() ? "" : CgeLocale.CORE_Inaccuracy);

EditorGUILayout.Separator();
EditorGUI.BeginDisabledGroup(serializedObject.isEditingMultipleObjects);
Expand Down
63 changes: 35 additions & 28 deletions ...ts/Hai/ExpressionsEditor/Scripts/Editor/EditorUI/EditorWindows/EeAnimationEditorWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,20 +85,26 @@ private void OnGUI()
GUILayout.BeginHorizontal();
if (!_accessCommands.HasActiveClip())
{
EditorGUILayout.TextField("No animation selected.", GUILayout.ExpandWidth(true));
EditorGUILayout.TextField(EeLocale.EEA_No_animation_selected, GUILayout.ExpandWidth(true));
}
else
{
_currentClipAssetRename = EditorGUILayout.TextField(_currentClipAssetRename, GUILayout.ExpandWidth(true));
}
EditorGUI.BeginDisabledGroup(!_accessCommands.HasActiveClip() || _currentClipAssetRename == currentClip.name || File.Exists(NewPath(currentClip)));
if (GUILayout.Button("Rename", GUILayout.Width(70)))
if (GUILayout.Button(EeLocale.EEA_Rename, GUILayout.Width(70)))
{
AssetDatabase.MoveAsset(AssetDatabase.GetAssetPath(currentClip), NewPath(currentClip));
}
EditorGUI.EndDisabledGroup();
GUILayout.EndHorizontal();

if (GUILayout.Button(EeLocale.CORE_Switch))
{
EeLocalization.CycleLocale();
}
EditorGUILayout.LabelField(EeLocalization.IsEnglishLocaleActive() ? "" : EeLocale.CORE_Inaccuracy);

UiPreviewSetup();
UiPreviewCamera();
if (!_accessCommands.HasActiveClip())
Expand All @@ -118,13 +124,13 @@ private void OnGUI()

if (_accessCommands.AllPreviewSetups().Count > 0)
{
if (ColoredBackground(_accessCommands.IsMaintaining(), Color.green, () => GUILayout.Button("Preview animation in Scene")))
if (ColoredBackground(_accessCommands.IsMaintaining(), Color.green, () => GUILayout.Button(EeLocale.EEA_Preview_animation_in_scene)))
{
_previewCommands.ToggleMaintainPreview();
}

EditorGUI.BeginDisabledGroup(!_accessCommands.IsMaintaining());
var scenePreviewMode = (EeAnimationEditorScenePreviewMode)EditorGUILayout.EnumPopup("Scene previews", _accessCommands.GetScenePreviewMode());
var scenePreviewMode = (EeAnimationEditorScenePreviewMode)EditorGUILayout.EnumPopup(EeLocale.EEA_Scene_previews, _accessCommands.GetScenePreviewMode());
if (scenePreviewMode != _accessCommands.GetScenePreviewMode())
{
_previewCommands.SetForcePreviewGeneration(scenePreviewMode);
Expand All @@ -133,13 +139,13 @@ private void OnGUI()

var dummy = _accessCommands.DummyNullable();
EditorGUI.BeginDisabledGroup(!dummy.HasValue);
if (GUILayout.Button("Select animator to edit Animation"))
if (GUILayout.Button(EeLocale.EEA_Select_animator_to_edit_animation))
{
Selection.SetActiveObjectWithContext(dummy.Value.Dummy.gameObject, null);
}
EditorGUI.EndDisabledGroup();

if (GUILayout.Button("Generate previews"))
if (GUILayout.Button(EeLocale.EEA_Generate_previews))
{
OnNewSweepRequested();
}
Expand Down Expand Up @@ -177,7 +183,7 @@ private void OnGUI()
GUILayout.BeginHorizontal();
GUILayout.Label("", GUILayout.ExpandWidth(true));
GUILayout.Label(_accessCommands.GetBasedOnWhat(editableProperty.Property) != null ? "Based" : "", GUILayout.Width(40));
if (GUILayout.Button("Delete", GUILayout.Width(StandardWidth / 5)))
if (GUILayout.Button(EeLocale.EEA_Delete, GUILayout.Width(StandardWidth / 5)))
{
_editCommands.DeleteBlendshape(editableProperty.Path, editableProperty.Property);
}
Expand All @@ -204,11 +210,11 @@ private void OnGUI()
var stats = _accessCommands.NonEditableStats();
if (stats.SmrMimicBlendshapes.Count > 0)
{
GUILayout.Label($"{stats.SmrMimicBlendshapes.Count} reset blendshapes are not shown above.", EditorStyles.boldLabel);
_foldoutMassEdit = EditorGUILayout.Foldout(_foldoutMassEdit, "Show/Delete reset blendshapes");
GUILayout.Label(string.Format(EeLocale.EEA_Reset_blendshapes_are_not_shown_above, stats.SmrMimicBlendshapes.Count), EditorStyles.boldLabel);
_foldoutMassEdit = EditorGUILayout.Foldout(_foldoutMassEdit, EeLocale.EEA_Show_delete_reset_blendshapes);
if (_foldoutMassEdit)
{
if (ColoredBackground(true, Color.red, () => GUILayout.Button("Delete 0-values")))
if (ColoredBackground(true, Color.red, () => GUILayout.Button(EeLocale.EEA_Delete_zero_values)))
{
_editCommands.DeleteAllNeutralizedBlendshapes();
}
Expand All @@ -221,35 +227,36 @@ private void OnGUI()
}
if (stats.HasAnyOtherStats)
{
GUILayout.Label("This animation has additional properties not shown here:");
LookupLabel(stats, EeNonEditableLookup.Transform, "transform-related");
LookupLabel(stats, EeNonEditableLookup.Animator, "finger posing, other muscles, or Animator-related");
LookupLabel(stats, EeNonEditableLookup.MaterialSwap, "material swaps");
LookupLabel(stats, EeNonEditableLookup.Shader, "shader properties");
LookupLabel(stats, EeNonEditableLookup.GameObjectToggle, "game object toggles");
LookupLabel(stats, EeNonEditableLookup.Other, "other properties not cited above");
GUILayout.Label(EeLocale.EEA_This_animation_has_additional_properties_not_shown_here);
LookupLabel(stats, EeNonEditableLookup.Transform, EeLocale.EEA_Transform_related);
LookupLabel(stats, EeNonEditableLookup.Animator, EeLocale.EEA_Finger_posing_other_muscles_or_animator_related);
LookupLabel(stats, EeNonEditableLookup.MaterialSwap, EeLocale.EEA_Material_swaps);
LookupLabel(stats, EeNonEditableLookup.Shader, EeLocale.EEA_Shader_properties);
LookupLabel(stats, EeNonEditableLookup.GameObjectToggle, EeLocale.EEA_Game_object_toggles);
LookupLabel(stats, EeNonEditableLookup.Other, EeLocale.EEA_Other_properties_not_cited_above);
}

if (_isCgeInstalled)
{
if (stats.Quirk != EeQuirk.EmptyIssue && stats.Quirk != EeQuirk.FirstFrameIssue && stats.EffectiveFrameDuration > 1)
{
GUILayout.Label($"This animation lasts {stats.EffectiveFrameDuration} keyframes.", EditorStyles.boldLabel);
GUILayout.Label(string.Format(EeLocale.EEA_This_animation_lasts_keyframes, stats.EffectiveFrameDuration), EditorStyles.boldLabel);
}
}
else
{
if (stats.Quirk != EeQuirk.EmptyIssue && stats.EffectiveFrameDuration > 1)
{
GUILayout.Label($"This animation lasts {stats.EffectiveFrameDuration} keyframes.", EditorStyles.boldLabel);
GUILayout.Label(string.Format(EeLocale.EEA_This_animation_lasts_keyframes, stats.EffectiveFrameDuration), EditorStyles.boldLabel);
}
switch (stats.Quirk)
{
case EeQuirk.EmptyIssue:
EditorGUILayout.HelpBox($"This animation is empty. This will cause the animation to last {stats.EffectiveFrameDuration} keyframes.", MessageType.Warning);
EditorGUILayout.HelpBox(string.Format(EeLocale.EEA_This_animation_is_empty, stats.EffectiveFrameDuration), MessageType.Warning);
break;
case EeQuirk.FirstFrameIssue:
EditorGUILayout.HelpBox($"All of the keyframes are located on frame 0. This will cause the animation to last {stats.EffectiveFrameDuration} keyframes.", MessageType.Warning);

EditorGUILayout.HelpBox(string.Format(EeLocale.EEA_All_of_the_keyframes_are_frame_zero, stats.EffectiveFrameDuration), MessageType.Warning);
break;
case EeQuirk.OneFrame:
case EeQuirk.MoreThanOneFrame:
Expand All @@ -261,23 +268,23 @@ private void OnGUI()

if (editableProperties.Any(info => info.IsVaryingOverTime))
{
EditorGUILayout.HelpBox("This animation contains blendshapes that are animated differently over time.\nThey cannot be edited in Expressions Editor. Preview may not be accurate.", MessageType.Info);
EditorGUILayout.HelpBox(EeLocale.EEA_BlendshapeVaryingOverTimeWarning, MessageType.Info);
}

var clipName = _accessCommands.ActiveClip().name;
if (clipName.Contains("Autogenerated") || clipName.Contains("DO_NOT_EDIT"))
{
EditorGUILayout.HelpBox("This animation is likely auto-generated and may be overwritten at any time. You should probably not edit it.", MessageType.Error);
EditorGUILayout.HelpBox(EeLocale.EEA_AutogeneratedAnimationWarning, MessageType.Error);
}

#if VRC_SDK_VRCSDK3
if (editableProperties.Any(info => info.Property.ToLowerInvariant().StartsWith("blendshape.vrc.v_")))
{
EditorGUILayout.HelpBox("This animation animates blendshapes that begin with vrc.v_, usually designed for Visemes.\nIf any animation contains those, the mouth may not animate properly.", MessageType.Warning);
EditorGUILayout.HelpBox(EeLocale.EEA_VrcVisemeBlendshapeWarning, MessageType.Warning);
}
if (editableProperties.Any(info => info.Property.ToLowerInvariant().Equals("blendshape.blink")))
{
EditorGUILayout.HelpBox("This animation animates a blendshape called Blink, usually selected to make the avatar blink automatically.\nIf any animation contains it, the avatar may not blink properly.\nMany avatar bases have blendshapes to close each eye separately; they should be used instead.", MessageType.Warning);
EditorGUILayout.HelpBox(EeLocale.EEA_BlinkBlendshapeWarning, MessageType.Warning);
}
#endif

Expand All @@ -302,7 +309,7 @@ private void UiPreviewSetup()

var previewSetups = available.Select(previewable => previewable.AsGameObject().name).ToArray();
if (previewSetups.Length == 0) previewSetups = new[] { "None" };
var newSelectedPreviewSetup = EditorGUILayout.Popup("Preview dummy", _selectedPreviewSetup, previewSetups);
var newSelectedPreviewSetup = EditorGUILayout.Popup(EeLocale.EEA_PreviewDummy, _selectedPreviewSetup, previewSetups);
if (newSelectedPreviewSetup != _selectedPreviewSetup)
{
_selectedPreviewSetup = newSelectedPreviewSetup;
Expand All @@ -320,7 +327,7 @@ private void UiPreviewSetup()

if (_accessCommands.AllPreviewSetups().Count == 0)
{
if (GUILayout.Button("Automatically setup preview!", GUILayout.Height(50), GUILayout.Width(300)))
if (GUILayout.Button(EeLocale.EEA_Automatically_setup_preview, GUILayout.Height(50), GUILayout.Width(300)))
{
new EePreviewSetupWizard().AutoSetup();
}
Expand All @@ -339,7 +346,7 @@ private void UiPreviewCamera()
cameras = dummy.Value.Cameras.Select(camera => camera.name).ToArray();
}

var newSelectedCamera = EditorGUILayout.Popup("Camera", _selectedPreviewCamera, cameras);
var newSelectedCamera = EditorGUILayout.Popup(EeLocale.EEA_Camera, _selectedPreviewCamera, cameras);
if (newSelectedCamera != _selectedPreviewCamera)
{
_selectedPreviewCamera = newSelectedCamera;
Expand Down
14 changes: 7 additions & 7 deletions ...s/Hai/ExpressionsEditor/Scripts/Editor/EditorUI/EditorWindows/EePropertyExplorerWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,19 @@ private void OnGUI()

GUILayout.BeginHorizontal();
GUILayout.BeginVertical();
_hotspotMode = GUILayout.Toggle(_hotspotMode, "Show Hotspots (press SPACE key)");
_hotspotMode = GUILayout.Toggle(_hotspotMode, EeLocale.EEP_Show_hotspots);

if (GUILayout.Button("Generate previews"))
if (GUILayout.Button(EeLocale.EEP_Generate_previews))
{
OnNewScanRequested();
}

_foldoutMoreTools = EditorGUILayout.Foldout(_foldoutMoreTools, "Other tools");
_foldoutMoreTools = EditorGUILayout.Foldout(_foldoutMoreTools, EeLocale.EEP_Other_tools);
if (_foldoutMoreTools)
{
GUILayout.BeginHorizontal();
GUILayout.Space(20);
if (EeAnimationEditorWindow.ColoredBackground(_basedOnSomethingElseMode, Color.green, () => GUILayout.Button("Fix Tooth and other hidden blendshapes")))
if (EeAnimationEditorWindow.ColoredBackground(_basedOnSomethingElseMode, Color.green, () => GUILayout.Button(EeLocale.EEP_Fix_tooth_and_other_hidden_blendshapes)))
{
_basedOnSomethingElseMode = !_basedOnSomethingElseMode;
}
Expand Down Expand Up @@ -143,7 +143,7 @@ private void OnGUI()
EditorGUI.BeginDisabledGroup(true);
GUILayout.TextField(onWhat.Substring(BlendshapePrefix.Length), GUILayout.ExpandWidth(true));
EditorGUI.EndDisabledGroup();
if (EeAnimationEditorWindow.ColoredBackground(true, Color.red, () => GUILayout.Button("Forget", GUILayout.Width(70))))
if (EeAnimationEditorWindow.ColoredBackground(true, Color.red, () => GUILayout.Button(EeLocale.EEP_Forget, GUILayout.Width(70))))
{
_editCommands.DeleteBasedSubject(info.Property);
}
Expand All @@ -152,7 +152,7 @@ private void OnGUI()
{
var isSelected = _basedOnSomethingElseSelection.Contains(info.Property);
EditorGUI.BeginDisabledGroup(_accessCommands.IsOnWhat(info.Property));
if (EeAnimationEditorWindow.ColoredBackground(isSelected, Color.green, () => GUILayout.Button("Select", GUILayout.Width(70))))
if (EeAnimationEditorWindow.ColoredBackground(isSelected, Color.green, () => GUILayout.Button(EeLocale.EEP_Select, GUILayout.Width(70))))
{
if (isSelected)
{
Expand All @@ -165,7 +165,7 @@ private void OnGUI()
}
EditorGUI.EndDisabledGroup();
EditorGUI.BeginDisabledGroup(isSelected || _basedOnSomethingElseSelection.Count == 0);
if (GUILayout.Button("Assign"))
if (GUILayout.Button(EeLocale.EEP_Assign))
{
_editCommands.AssignBased(info.Property, _basedOnSomethingElseSelection.ToList());
_basedOnSomethingElseSelection.Clear();
Expand Down
Loading