Support v1 CRD API Version #325
Conversation
|
Hi @awh21 , You are also welcome to skuber discord channel |
|
@hagay3 Thanks! I wasn't expecting you to spot this so soon whilst it's still in draft 😅 Like I said in the description we're using this lib at work for some K8s operators and support for v1 CRDs would make our lives much easier. I don't think the dynamic client supports the watch operations we want to use in our K8s operators fwiw, though I could be missing something there Is v1 CRD support something you'd be up for adding to the library? If not, give me a shout and my team will figure out a way around this internally so no big deal Also, is there a way to run all these PR checks locally with the various versions of K8s required within Minikube? Anyways, looks like I need to spend some more time getting the tests to work for all these Scala/K8s versions so let me do that in the mean time |
|
Incorporating the v1 CRD into skuber is an excellent idea! I'm eager to contribute and support this effort. Please feel free to reach out and let me know what additional assistance or resources are required to make this integration a success. I'm here to help in any way I can. In order to run integration tests on your laptop you need to install docker and minikube. You can use this small script to install minikube: https://github.com/hagay3/skuber/blob/master/infra/ci/minikube-commands.sh Change the v1.19.6 for deleting a cluster |
…erent Kind is used from v1beta1 CRD test
… annotations for implicits, for compatibility with Scala 3
|
Hey @hagay3, hope you had a good weekend! The tests are passing locally so if you wouldn't mind kicking off the workflow for this PR please that'd be great 🙏 I'm hoping we're good to go with this change now, pending review of course! |
|
@awh21 I have disabled the workflow approval also, please fix the docs for custom resources in case needed thanks :) |
…d fix flakiness in watch test
…ation to the docs
| versions: List[Version] | ||
| ): CustomResourceDefinition = { | ||
| if (versions.exists(v => v.schema.isEmpty)) | ||
| throw new Exception("Schema must be specified in CRD v1 version") |
There was a problem hiding this comment.
Ah because the ResourceSpecification.Version class is used by both v1beta1 and v1 CRDs, but the Schema is only used in v1 (where it is mandatory). I agree it's a little clunky, but I wasn't sure of the best way around it
Maybe splitting it into a base Version trait and then specific classes like CRDv1Version (which would include the Schema as a mandatory field) would be better, I'm not sure. Happy with whatever approach you think is best!
|
migration notes for CustomResourceDefinition (v1beta1): |
|
LGTM |
Awesome stuff! Thank you for the assistance and speedy replies/action :) |
Relates to #155
The apiextensions.k8s.io/v1beta1 API version for CRDs is deprecated in v1.22+ of Kubernetes, and a new v1 API version is supported instead. The changes are listed here: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#customresourcedefinition-v122
This PR adds v1 CRD support and moves the existing v1beta1 CRD implementations under a
v1beta1package. It is mostly porting changes introduced to doriordan/skuber in this commit: doriordan/skuber@dbbd839#diff-04a4c27859310f1477c9c3419c74682573418993db9b51912b0b5f84167ec427My team at work are using Skuber as part of some work to implement deployment mechanisms involving K8s operators - and the K8s clusters we're deploying into are on v1.24 - which only supports v1 CRDs. We would appreciate a review on this (and hopefully an approval and release!) whenever you can please! Worst case, if you don't want to add this capability for whatever reason let me know, we can publish a fork of this internally to use