Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added storageClassName to PersistentVolume Spec #277

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

threeseed
Copy link

StorageClassName is a valid attribute to the PersistentVolumeSpec:
https://docs.openshift.com/container-platform/3.11/rest_api/core/persistentvolume-core-v1.html

And needed to use the Yandex S3 CSI Driver.

@hagay3
Copy link
Owner

hagay3 commented Apr 5, 2023

@nadenf
Thanks a lot for opening the PR and contributing to skuber!
can you also add unit tests in VolumeReadWriteSpec ?

Copy link
Owner

@hagay3 hagay3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hagay3 hagay3 merged commit 9ee406d into hagay3:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants