Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionPoolSettings taken from local Skube's appConfig when available #275

Merged
merged 3 commits into from
Mar 21, 2023
Merged

ConnectionPoolSettings taken from local Skube's appConfig when available #275

merged 3 commits into from
Mar 21, 2023

Conversation

arkadius
Copy link
Contributor

Resolves #274

hagay3
hagay3 requested changes Mar 21, 2023
View reviewed changes
Copy link
Owner

@hagay3 hagay3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments

hagay3
hagay3 requested changes Mar 21, 2023
View reviewed changes
Copy link
Owner

@hagay3 hagay3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backward compatible

@hagay3 hagay3 merged commit 6e393a8 into hagay3:master Mar 21, 2023
@hagay3
Copy link
Owner

hagay3 commented Mar 21, 2023

@arkadius
Thanks a lot for opening the PR and contributing to skuber!
I will create a new release shortly.

@arkadius
Copy link
Contributor Author

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hagay3 hagay3 hagay3 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Http client settings taken from ActorSystem settings
2 participants
@arkadius @hagay3