Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automountServiceAccountToken to ServiceAccount #261

Merged
merged 3 commits into from
Dec 31, 2022
Merged

Add automountServiceAccountToken to ServiceAccount #261

merged 3 commits into from
Dec 31, 2022

Conversation

SakulK
Copy link
Contributor

@SakulK SakulK commented Dec 29, 2022 •
edited
Loading

@SakulK SakulK changed the title Add automountServiceAccountToken to ServiceAccount Add automountServiceAccountToken to ServiceAccount Dec 29, 2022
@hagay3
Copy link
Owner

hagay3 commented Dec 29, 2022

@SakulK
Thank you for opening the PR and contributing to skuber!
I think it's a good opportunity to add integration tests to ServiceAccount, wdyt?

e.g:
https://github.com/hagay3/skuber/blob/master/client/src/it/scala/skuber/ServiceSpec.scala

@SakulK
Copy link
Contributor Author

SakulK commented Dec 30, 2022

@hagay3
Sure, I created a basic test suite based on the ServiceSpec plus an additional case for automountServiceAccountToken, let me know if it's good enough 🙂

@hagay3
Copy link
Owner

hagay3 commented Dec 31, 2022

@SakulK
Fantastic work! I will create a new release shortly.

@hagay3 hagay3 merged commit 22fed51 into hagay3:master Dec 31, 2022
@SakulK SakulK deleted the automountServiceAccountToken branch December 31, 2022 12:55
@hagay3
Copy link
Owner

hagay3 commented Jan 1, 2023 •
edited
Loading

@SakulK
v3.0.4 released
https://github.com/hagay3/skuber/releases/tag/v3.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SakulK @hagay3