Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fnat - energy scatter plots #725

Merged
merged 3 commits into from
Nov 7, 2023
Merged

added fnat - energy scatter plots #725

merged 3 commits into from
Nov 7, 2023

Conversation

mgiulini
Copy link
Contributor

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #720

@mgiulini mgiulini self-assigned this Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31155b3) 70.25% compared to head (ee66e46) 70.25%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #725   +/-   ##
=======================================
  Coverage   70.25%   70.25%           
=======================================
  Files          78       78           
  Lines        6967     6967           
=======================================
  Hits         4895     4895           
  Misses       2072     2072           
Files Coverage Δ
src/haddock/libs/libplots.py 96.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgiulini mgiulini marked this pull request as ready for review October 16, 2023 14:58
@mgiulini mgiulini requested a review from amjjbonvin October 16, 2023 15:03
@rvhonorato rvhonorato added enhancement Enhancing an existing feature of adding a new one analysis/postprocessing related to the analysis/postprocessing of a haddock3 run labels Oct 24, 2023
@mgiulini mgiulini requested a review from VGPReys November 6, 2023 14:30
VGPReys
VGPReys previously approved these changes Nov 6, 2023
@mgiulini mgiulini merged commit 30373a2 into main Nov 7, 2023
6 checks passed
@mgiulini mgiulini deleted the fnat_plots branch November 7, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis/postprocessing related to the analysis/postprocessing of a haddock3 run enhancement Enhancing an existing feature of adding a new one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add fnat - energetic components scatter plots
3 participants