Upstream fstar core changes from cryspen-sandwich. #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
reviewed
Nov 13, 2024
W95Psp
approved these changes
Nov 13, 2024
maximebuyse
force-pushed
the
sandwich-core-changes
branch
from
d1a7db4
to
3d5d7aa
Compare
maximebuyse
force-pushed
the
sandwich-core-changes
branch
from
3d5d7aa
to
18cd120
Compare
|
I don't understand the CI failure. The core changes are unrelated to the error, and chacha20 type-checking works locally for me (maybe updating the fstar version used by the CI could help?) |
maximebuyse
force-pushed
the
sandwich-core-changes
branch
from
3813f42
to
c49e5f0
Compare
After rebasing the CI passes. Let's merge. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #979