Use timezone aware objects for RepositoryData.last_fetched #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhaus
approved these changes
Apr 8, 2024
emontnemery
force-pushed
the
fix_last_fetched
branch
from
601f997 to
61b78a7
Compare
emontnemery
force-pushed
the
fix_last_fetched
branch
from
61b78a7 to
a82fdbc
Compare
ludeeus
approved these changes
Apr 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR,
RepositoryData.last_fetchedis in some cases a naïve UTC time, and in some cases a naïve local time, which causes problem when comparing timstamps