Bump Fourmolu to 0.7 #563
Merged
Bump Fourmolu to 0.7 #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgefst
commented
Jul 11, 2022
| @@ -22,7 +22,7 @@ import Rel8 ( | |||
| Result, | |||
| namesFromLabels, | |||
| ) | |||
| import qualified Rel8 ( | |||
| import Rel8 qualified ( | |||
There was a problem hiding this comment.
This is because we're now using GHC2021, which enables ImportQualifiedPost. Running Fourmolu 0.6 on the command line doesn't apply this styling because it doesn't look for extensions in the cabal file.
| && gc1 | ||
| `M.isSubmapOf` gc2 | ||
| && sh1 | ||
| == sh2 |
There was a problem hiding this comment.
This seems to be a victim of Ormolu 0.5's operator fixity overhaul. I'll investigate upstream.
There was a problem hiding this comment.
I'll investigate upstream.
dhess
approved these changes
Jul 12, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #502 (comment), our CLI and HLS versions of Fourmolu were out of sync. This re-aligns them. So we can now turn format-on-save back on in our editors.
It would be nice if this wasn't a requirement. This is why I implemented haskell/haskell-language-server#2763, but it isn't clear whether that's currently usable.
As for the actual formatting changes introduced by bumping Fourmolu, they're all ultimately from Ormolu (so it's not my fault!).