Tell Fourmolu about Foreword operator fixities #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Can you please add |
dhess
requested changes
Nov 27, 2024
georgefst
force-pushed
the
georgefst/fourmolu-foreword-operators
branch
from
2895656
to
2a0c3ea
Compare
|
Ah yes, I'd forgotten about Conventional Commits after not working on this project for a while. My contributions to #1304 have the same problem... |
This basically reverts f016a8a. These changes have been manually reviewed, and some alterations made regarding line breaks, in order to return to the state before that commit, and to improve the formatting of some newer code. For example, see `&& length vs1 == length vs2` in `primer/src/Primer/Core/Utils.hs`. Signed-off-by: George Thomas <[email protected]>
Signed-off-by: George Thomas <[email protected]>
georgefst
force-pushed
the
georgefst/fourmolu-foreword-operators
branch
from
2a0c3ea
to
4353938
Compare
dhess
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically reverts #1158. I wasn't really actively involved with Fourmolu at the time that Ormolu overhauled its operator handling, or else I would have noticed that the huge diff in that PR was due to an awkward interaction between that new feature and custom preludes (the release notes could have drawn attention to this, and I intend to improve the documentation myself when I get a chance).