chore: upgrade Hedgehog to version 1.4 #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brprice
force-pushed
the
brprice/hedgehog-1.4
branch
from
f6a8a1b
to
e5ff05e
Compare
brprice
commented
Aug 17, 2023
Comment on lines
+12
to
+13
| allow-newer: hedgehog-classes:hedgehog | ||
|
|
There was a problem hiding this comment.
I intentionally did not sign-off this commit so CI would break and this would not be merged without discussing:
- Do we want to merge this with
allow-newer(if so, I need to reword the commit message to be conventional-commits, and maybe rebase it first so both commits will build cleanly; I'll not squash, to make it trivial to revert once upstream makes a release) - Do we want to wait for upstream to fix it (bump hedgehog upper bound 1.3 -> 1.5 hedgehogqa/haskell-hedgehog-classes#52)
- Did we want some other option?
There was a problem hiding this comment.
I think this is fine. It's more important that we get the GHC 9.6 work moving.
There was a problem hiding this comment.
Upstream plans to cut a new release this weekend, so I'll wait until next week to merge this.
There was a problem hiding this comment.
Let's merge. I have opened #1122 to track removing the allow-newer when a release happens.
This is in preparation for the next commit, which upgrades hedgehog to 1.4. This commit can be reverted once hedgehog-classes makes a new release: upstream has merged a patch widening their bounds, but it is not yet released. Signed-off-by: Ben Price <[email protected]>
This needs a few simple fixes due to `Gen.element` now being polymorphic, which interacts slightly badly with overloaded lists. Signed-off-by: Ben Price <[email protected]>
brprice
force-pushed
the
brprice/hedgehog-1.4
branch
from
e5ff05e
to
b50d443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Hedgehog 1.4 has been released with the fix for replaying tests, we can migrate off 1.1. This is a prerequisite for upgrading ghc to 9.6 (#1077).
Note that currently we need to
allow-newerto get hedgehog-classes to work with hedgehog 1.4; I have opened an upstream PR at hedgehogqa/haskell-hedgehog-classes#52