HCK-7072: fix sonar issues (#73)

hackolade · Jul 12, 2024 · aa146fb · aa146fb
1 parent 2e1e516
commit aa146fb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/forward_engineering/helpers/commentIfDeactivated.js b/forward_engineering/helpers/commentIfDeactivated.js
@@ -1,5 +1,5 @@
 const BEFORE_DEACTIVATED_STATEMENT = '-- ';
-const REG_FOR_MULTYLINE_COMMENT = /(\n\/\*\n[\s\S]*?\n\s\*\/\n)|(\n\/\*\n[\s\S]*?\n\s\*\/)$/gi;
+const REG_FOR_MULTYLINE_COMMENT = /(\n\/\*\n[\s\S]*?\n\s\*\/\n)$|(\n\/\*\n[\s\S]*?\n\s\*\/)$/gi;
 
 const commentIfDeactivated = (statement, data, isPartOfLine) => {
 	if (data?.hasOwnProperty('isActivated') && !data.isActivated) {

diff --git a/reverse_engineering/reverseEngineeringService/helpers/reorderTableRows.js b/reverse_engineering/reverseEngineeringService/helpers/reorderTableRows.js
@@ -7,7 +7,7 @@ const reorderTableRows = (tableRows, isFieldOrderAlphabetic) => {
 		return tableRows;
 	}
 
-	const reorderedFieldNames = Object.keys(tableRows[0]).sort();
+	const reorderedFieldNames = Object.keys(tableRows[0]).sort((a, b) => a?.localeCompare?.(b));
 	return tableRows.map(row =>
 		Object.values(row).reduce(
 			(columns, columnValue, i) => ({

diff --git a/reverse_engineering/reverseEngineeringService/helpers/reverseTableColumn.js b/reverse_engineering/reverseEngineeringService/helpers/reverseTableColumn.js
@@ -9,8 +9,8 @@ const handleDefault = (typeObject, value) => {
 	const validValue =
 		{
 			numeric: Number(value.replace(/(^\(\()|(\)\)$)/g, '')),
-			char: value.replace(/(^\(\')|(\'\))$/g, ''),
-			xml: value.replace(/(^\(N\')|(\'\))$/g, ''),
+			char: value.replace(/(^\(')$|('\))$/g, ''),
+			xml: value.replace(/(^\(N')$|('\))$/g, ''),
 		}[typeObject.type] || value;
 
 	return { default: validValue };