update pull_request_template with onboard notice #7803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
role: front end
|
ETA: 12/17/24 |
DrAcula27
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
@codyjohnsontx Great job on your Small Issue! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
.github/pull_request_template.mdwas edited - No extra edits were made
- Appearance of the website is unchanged (Chrome and Firefox)
- A minor nitpick: did you mean to include the issue number after this text?
Add message at top of pull_request_template.md indicated in issue:
Approved! 👍
31 tasks
|
Review ETA: end of 12/17/2024 |
mchait18
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Thank you for working on this issue, @codyjohnsontx !
You're doing these right:
- The branch you made the change on is correct
- The linked issue (original issue) number is included
- The content required to add is accurate
- The CodeQL Alerts are checked (check box above)
Great job!
Things to review:
- Not all items on the original issue are checked
belunatic
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
@codyjohnsontx great job, a fantastic work
- The branch name is on point
- great job and letting us know what changed
- The links works
- Everything is checked on the original issue
Way to end the year with a bang! lol!
Thanks again for you hardwork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7722
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied