-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "Learn more" link visible on Redesigned Homepage and link it to About Page #7793
Make "Learn more" link visible on Redesigned Homepage and link it to About Page #7793
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
@codyyjxn , please provide your Review ETA and Availability when assigning yourself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things that went well:
-The file change is correct with uncomment code.
-The title is concise and the description is also clear.
Some suggestions
- You need to change the P: HfLA Website: Project Board :
Prioritized backlog
toIn Progress
@codyyjxn Thank you for that I went ahead and changed the status. |
EtaWithin the hour Availability5-9 pm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What looks good
- What changes you made look good
- Reason for changes look good
- Branch name looks good
- Code changes looks good
- Visual changes looks good
Everything looks good to me.
Review ETA: 12:30 PM 12/10/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this issue, @belunatic !
You're doing these right:
The branch you made the change on is correct
The linked issue (original issue) number is included
The content required to be removed is accurate
The CodeQL Alerts are checked (check box above)
The screenshots are clear
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@belunatic Great job on your Small Issue
! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
_includes/home-page/hero.html
was edited - No extra edits were made
- Commit is in the correct feature branch
- Appearance of the website looks good in Chrome and Firefox
Approved! 👍
9bb311e
into
hackforla:feature-homepage-launch
Fixes #7689
What changes did you make?
_includes/home-page/hero.html
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied