Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Melissa Perry to the Current Project Team section #7723

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

belunatic
Copy link
Member

@belunatic belunatic commented Nov 17, 2024

Fixes #7647

What changes did you make?

  • I added Melissa Perry to the Current Project Team section

Why did you make the changes (we will use this info to test)?

  • to updated the team roster as requested

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

FireShot Capture 073 - LA TDM Calculator - Hack for LA - localhost

Visuals after changes are applied

FireShot Capture 074 - LA TDM Calculator - Hack for LA - localhost

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b belunatic-add-melissa-perry-7647 gh-pages
git pull https://github.com/belunatic/website.git add-melissa-perry-7647

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 17, 2024
@maadeshsivakumar maadeshsivakumar self-assigned this Nov 17, 2024
@maadeshsivakumar
Copy link
Member

Review ETA: 10 AM 11/17/24
Availability: 5-8 PM Everyday

Copy link
Member

@maadeshsivakumar maadeshsivakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@belunatic Great job on your Pull Request! Thank you for your contribution keep it up !

@trimakichan
Copy link
Member

Review ETA: 11/18/24
Availability: 10 AM to 5 PM Weekdays

@t-will-gillis
Copy link
Member

t-will-gillis commented Nov 17, 2024

Hi @maadeshsivakumar You have selected to assign yourself to this PR as shown here:

Screenshot 2024-11-17 093504

Reviewers do not assign themselves to PRs that they are reviewing. Please go to "Assignees", select the gear, and then un-assign yourself. Thank you!

@maadeshsivakumar maadeshsivakumar removed their assignment Nov 17, 2024
Copy link
Member

@trimakichan trimakichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on working on this issue, @belunatic !

  • The branch name includes the issue number and is appropriately named.
  • The issue is linked correctly.
  • Before and after screenshots are provided to show the changes.
  • The code changes are correct.
  • CodeQL Alerts was checked.

Suggestions:

  • Consider revising the title to make it more specific about the files you changed.

  • In the What changes did you make? section, please specify the file(s) you edited. This would be very helpful.
    Example: File changed: projects/tdm-calculator.md

  • Check the box on the linked issue (original issue) that says:
    "Verify the changes by viewing the following in your local environment and include before and after screenshots with your pull request."

Thank you for your contribution! Keep up the great work!

@NolaDodd
Copy link
Member

Review ETA: 6 PM 11/17/24
Availability: 2-8 PM Sunday

@santisecco
Copy link
Member

Review ETA: 16 PM 11/17/24
Availability: 2-8 PM Sun-Monday

Copy link
Member

@NolaDodd NolaDodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @belunatic !

Everything is done correctly; the branch name is correct, the issue is linked, and changes are reflected in the new branch and screenshots.

Notes:

  • The title is a little unclear. "I added Melissa Perry to the Current Project Team section" doesn't specify which one, since there are MANY different teams across Hack for LA. It would be good to specify that it's for the LA TDM Calculator team. A link to the section would be nice as well. (The original issue has a link in it's subnotes: https://www.hackforla.org/projects/tdm-calculator )

  • Specifying which file you changed would be nice as well, so we don't have to search for it.

Otherwise, great job!

Copy link
Member

@santisecco santisecco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @belunatic everything looks great. Code changes are correct and branches are correct. For next time, please be a bit more descriptive in the Why and What sections as these are very important as issues progress in difficulty and for the rest of the devs to further understand your code.
For example, you could include the path of the file you are editing in the What section.
For completeness also please check all the boxes in the issue #7647 and/or ask if you need help resolving some of them. I understand some may remain unchecked but I see one like "Find the leadership variable and add the following profile." that could be checked.

Besides that, the changes look awesome in my local version of the website. Thanks for working on this!

@t-will-gillis
Copy link
Member

Hi @belunatic Looks good! Before your next PR, please make sure to read through the comments above - there are many good observations here to keep in mind. Thanks!

@t-will-gillis t-will-gillis merged commit 14c49b9 into hackforla:gh-pages Nov 18, 2024
9 checks passed
@belunatic belunatic deleted the add-melissa-perry-7647 branch November 18, 2024 17:53
@belunatic
Copy link
Member Author

@NolaDodd, @trimakichan, and @santisecco, I want to thank you all for the feedback you left for me. I will integrate it in my next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: LA TDM Calculator Add Melissa Perry
6 participants