Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website.md, remove Mario Anonini, #7459 #7718

Merged

Conversation

codyjohnsontx
Copy link
Member

@codyjohnsontx codyjohnsontx commented Nov 13, 2024

Fixes #7459

What changes did you make?

  • Delete Mario Anonini and relevant data from HackforLA website
  • Current Project Team Page

Why did you make the changes (we will use this info to test)?

  • To keep list of Current Project Team members up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Before
remove-Mario-Antonini-(before)-7459

Visuals after changes are applied

After
remove-Mario-Antonini-7459

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b codyjohnsontx-remove-Mario-Antonini-7459 gh-pages
git pull https://github.com/codyjohnsontx/website.git remove-Mario-Antonini-7459

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 13, 2024
@siyunfeng siyunfeng self-requested a review November 14, 2024 04:04
@siyunfeng
Copy link
Member

Review ETA: 11/15/2024 Friday
Availability: 6-10 PM Weekdays (EDT)

Copy link
Member

@siyunfeng siyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue, @codyjohnsontx !

You're doing these right:

  • The branch you made the change on is correct
  • The linked issue (original issue) number is included
  • The content required to remove is accurate
  • The CodeQL Alerts are checked
  • The after screenshot is helpful to display the change

Changes you need to make:

  • Address the questions from HackforLABot in the original issue (Availability and ETA)
  • Fix the unnecessary changes and submit your PR again (It could be caused by the formatting tool in your IDE, such as prettier)
  • Fix the before-and-after screenshots section (The images are not showing)

You can re-request me to review your PR once you make the changes. Feel free to reach out if you have any questions.

@codyjohnsontx
Copy link
Member Author

Availability for this week: Friday 4-6, Saturday 10-4, Sunday 10-4

My estimated ETA for completing this issue: 30 minutes to 1 hour

Copy link
Member

@siyunfeng siyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job fixing the quotation marks in the file, @codyjohnsontx .

Things to improve:

  • You only need to address your availability and ETA in the original issue (the linked issue you mentioned in your PR Update Project Profile: remove Mario Antonini from HackforLA.org Website #7459)
  • Move the before-and-after screenshots to this section Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
  • Check the changes requested by the reviewer once you make the changes

Other than these, everything looks good. Thank you for your contribution!

@DakuwoN DakuwoN self-assigned this Nov 15, 2024
@DakuwoN
Copy link
Member

DakuwoN commented Nov 15, 2024

Review ETA: 10PM 11/16/24
Availability: Everyday after 10:30AM CST

@mmcclanahan mmcclanahan self-requested a review November 16, 2024 02:41
@mmcclanahan
Copy link
Member

Nice Work @codyjohnsontx !
Proper into and from branches
Clear and simple what and why
Correctly removed the team members info

Thanks for the PR!

@DakuwoN DakuwoN removed their assignment Nov 16, 2024
@codyjohnsontx codyjohnsontx self-assigned this Nov 17, 2024
@t-will-gillis t-will-gillis merged commit 4fe92b2 into hackforla:gh-pages Nov 17, 2024
5 checks passed
@t-will-gillis
Copy link
Member

Hey @codyjohnsontx FYI- you do not need to assign yourself to your own PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: remove Mario Antonini from HackforLA.org Website
5 participants