-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates profiles in the civic tech jobs page #6764
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Availability: 4/26, 4/27 1-3PM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jono4727, great job on this issue!. The pull request comes from the correct branch and you linked the issue correctly. I've verified the changes locally and it looks good to me!
A question for the merge team: there was recently another pull request that updated the data for Melinda Sukosd in PR #6678, and I wanted to confirm that removing her profile here is intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jono4727,
The code change looks clean and accurate, and the changes to the website look good when tested locally.
However, I noticed that a submodule directory called 'website' was added in this pull request. Could you please remove the submodule and push the updated changes? Once that's done, the pull request will be ready for merging. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jono4727 - please remove this submodule directory and push the changes.
Thanks for checking @A-Wu5, removing Melinda's profile is the intended action. The issue to remove her profile was created after the issue to update her data. |
Fixes #6638
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
![image]
Visuals after changes are applied
![image]