Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates profiles in the civic tech jobs page #6764

Closed

Conversation

jonnyoe
Copy link
Member

@jonnyoe jonnyoe commented Apr 26, 2024

Fixes #6638

What changes did you make?

  • Removed Jen Chung, Melinda Sukosd, and Jenn Wu's profiles
  • Moved and updated Lu Feng's profile

Why did you make the changes (we will use this info to test)?

  • Keeps civic tech jobs project profiles and information up to date

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

![image]Screenshot 2024-04-25 at 7 48 27 PM

Visuals after changes are applied

![image]Screenshot 2024-04-25 at 7 45 20 PM

@jonnyoe jonnyoe requested a review from jphamtv April 26, 2024 03:00
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jono4727-update-project-profiles-6638 gh-pages
git pull https://github.com/jono4727/website.git update-project-profiles-6638

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jono4727/website/blob/update-project-profiles-6638/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 26, 2024
@A-Wu5 A-Wu5 self-requested a review April 26, 2024 08:55
@A-Wu5
Copy link
Member

A-Wu5 commented Apr 26, 2024

Availability: 4/26, 4/27 1-3PM
ETA: 4/26

Copy link
Member

@A-Wu5 A-Wu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jono4727, great job on this issue!. The pull request comes from the correct branch and you linked the issue correctly. I've verified the changes locally and it looks good to me!

@A-Wu5
Copy link
Member

A-Wu5 commented Apr 27, 2024

A question for the merge team: there was recently another pull request that updated the data for Melinda Sukosd in PR #6678, and I wanted to confirm that removing her profile here is intended.

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jono4727,
The code change looks clean and accurate, and the changes to the website look good when tested locally.

However, I noticed that a submodule directory called 'website' was added in this pull request. Could you please remove the submodule and push the updated changes? Once that's done, the pull request will be ready for merging. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jono4727 - please remove this submodule directory and push the changes.

@jphamtv
Copy link
Member

jphamtv commented Apr 27, 2024

A question for the merge team: there was recently another pull request that updated the data for Melinda Sukosd in PR #6678, and I wanted to confirm that removing her profile here is intended.

Thanks for checking @A-Wu5, removing Melinda's profile is the intended action. The issue to remove her profile was created after the issue to update her data.

@jonnyoe jonnyoe closed this Apr 30, 2024
@jonnyoe jonnyoe deleted the update-project-profiles-6638 branch April 30, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs (Remove Jen Chung, Melinda Sukosd, & Jenn Wu; Update Lu Feng)
3 participants