Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Profile: Food Oasis (Fix Hannah Zulueta's Slack link) #6325

Merged

Conversation

luisitocanlas
Copy link
Member

Fixes #6317

What changes did you make?

  • Updated Hannah Zulueta's Slack link at line 42.

Why did you make the changes (we will use this info to test)?

  • So that the link resolves to Hannah's active account.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b luisitocanlas-update-project-profile-6317 gh-pages
git pull https://github.com/luisitocanlas/website.git update-project-profile-6317

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/luisitocanlas/website/blob/update-project-profile-6317/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 20, 2024
@Anahisv23 Anahisv23 self-assigned this Feb 20, 2024
Copy link
Member

@Anahisv23 Anahisv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @luisitocanlas thanks for taking up the issue!

Here's what you did well:
• Commit into branch and from branch are correct
• There is a linked issue number
• Appropriate files and lines of code were changed
• Slack link was correctly updated and clicking the new slack link directs user to Hannah's active account

Overall great work! Keep it up :)

@irais-valenzuela irais-valenzuela self-assigned this Feb 21, 2024
@irais-valenzuela
Copy link
Member

Review ETA: 6:30 PM 2/20/24
Availability: 6-8 PM Monday

Copy link
Member

@irais-valenzuela irais-valenzuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @luisitocanlas, good job on the issue! The branches are correct, you linked the issue, and successfully updated the slack link. Nice job!

@t-will-gillis t-will-gillis merged commit 6df3b46 into hackforla:gh-pages Feb 21, 2024
10 checks passed
@luisitocanlas luisitocanlas deleted the update-project-profile-6317 branch February 23, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Food Oasis (Fix Hannah Zulueta's Slack link)
4 participants