Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cop redirection 5622 #5690

Merged
merged 7 commits into from
Oct 14, 2023
Merged

Fix cop redirection 5622 #5690

merged 7 commits into from
Oct 14, 2023

Conversation

dineshsk98
Copy link
Member

Fixes #5622

What changes did you make?

-changed path on line 7 in redirections/cop.md

Why did you make the changes (we will use this info to test)?

-fix broken path

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

272727955-20ab00b4-6ea2-426a-9bec-17165035440a

Visuals after changes are applied

272727950-112b04f0-8437-437c-9e88-6193c982c79c

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b dineshsk98-fix-cop-5622 gh-pages
git pull https://github.com/dineshsk98/hfla-website.git fix-cop-5622

@github-actions github-actions bot added Bug Something isn't working good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 10, 2023
@pdimaano pdimaano self-requested a review October 10, 2023 17:33
@pdimaano
Copy link
Member

ETA: 10/13/23
Availability: Weekday evenings

@Thinking-Panda
Copy link
Member

Availability: Weekdays
ETA: 10/11

@blulady blulady requested a review from mademarc October 11, 2023 02:17
pdimaano
pdimaano approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@pdimaano pdimaano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dineshsk98 Good job: The branches are correct and the issue is linked. The changes are visible on my system on desktop, mobile and tablet. The correct file was changed and the appropriate ending slash was removed. The included screenshots also reflect the redirect to the correct webpage. Well done!

@Thinking-Panda Thinking-Panda self-requested a review October 12, 2023 19:44
Thinking-Panda
Thinking-Panda approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@Thinking-Panda Thinking-Panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dineshsk98 , Well done. Branches are setup correctly, code changes are clean and as mentioned in the issue, website works well on my machine. Thank you !

@mademarc
Copy link
Member

Review ETA: 10/12/2023
Availability: 7:22PM

mademarc
mademarc approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dineshsk98 well done in fixing the issue on line 7.

@drakenguyen4000 drakenguyen4000 merged commit 0736276 into hackforla:gh-pages Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thinking-Panda Thinking-Panda Thinking-Panda approved these changes

@mademarc mademarc mademarc approved these changes

@pdimaano pdimaano pdimaano approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working good first issue Good for newcomers P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken CoP redirect
6 participants
@dineshsk98 @pdimaano @Thinking-Panda @mademarc @drakenguyen4000 @ds6332