-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HelloGOV image alt property value #4011
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 6 PM 2/20 Monday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The change can be seen when I run the site in my local environment.
Review ETA (PST): 9:15 PM 20FEB23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @srandolph2, good job on completing your first issue! The changes to the alt text for the hellogov.jpg
matches the changes in the issue and reflects on the website.
Could you reformat your pull request comment? Looks like the description of the change was formatted as a header instead of a bullet point.
This is optional, but I find adding a brief explanation of why we're making the changes helps with the review process (why update the alt text?).
Hello! I fixed the bullet point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srandolph2 Thanks for updating it! Good job on completing the issue
Fixes #4008
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website