Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HelloGOV image alt property value #4011

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

srandolph2
Copy link
Member

@srandolph2 srandolph2 commented Feb 20, 2023

Fixes #4008

What changes did you make and why did you make them ?

  • Fixed the image alt property value within _projects/hellogov.md to HelloGOV
  • Changed to make the alt easier to read

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b srandolph2-hello-gov-4008 gh-pages
git pull https://github.com/srandolph2/website.git hello-gov-4008

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Accessibility Issues that would broaden website accessibility size: 1pt Can be done in 4-6 hours labels Feb 20, 2023
@srandolph2 srandolph2 changed the title hello-gov-changed Update HelloGOV image alt property value Feb 20, 2023
@chrismenke45 chrismenke45 self-requested a review February 21, 2023 00:29
@chrismenke45
Copy link
Member

Review ETA: 6 PM 2/20 Monday
Availability: Now-6 PM 2/20 Monday

Copy link
Member

@chrismenke45 chrismenke45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The change can be seen when I run the site in my local environment.

@Adastros Adastros self-requested a review February 21, 2023 04:51
@Adastros
Copy link
Member

Review ETA (PST): 9:15 PM 20FEB23
Availability (PST): 9 - 10 PM 20FEB23

Copy link
Member

@Adastros Adastros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @srandolph2, good job on completing your first issue! The changes to the alt text for the hellogov.jpg matches the changes in the issue and reflects on the website.

Could you reformat your pull request comment? Looks like the description of the change was formatted as a header instead of a bullet point.

This is optional, but I find adding a brief explanation of why we're making the changes helps with the review process (why update the alt text?).

@srandolph2
Copy link
Member Author

Hi @srandolph2, good job on completing your first issue! The changes to the alt text for the hellogov.jpg matches the changes in the issue and reflects on the website.

Could you reformat your pull request comment? Looks like the description of the change was formatted as a header instead of a bullet point.

This is optional, but I find adding a brief explanation of why we're making the changes helps with the review process (why update the alt text?).

Hello! I fixed the bullet point

Copy link
Member

@Adastros Adastros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srandolph2 Thanks for updating it! Good job on completing the issue

@Adastros Adastros merged commit f99f600 into hackforla:gh-pages Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HelloGOV: Update alt text for HelloGOV image to adhere to WCAG
3 participants