Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark civic opporunity project on hold #3924

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Mark civic opporunity project on hold #3924

merged 1 commit into from
Feb 4, 2023

Conversation

mjh-projects
Copy link
Member

Fixes #3893

What changes did you make and why did you make them ?

  • changed word Active to On Hold for civic Opportunity Project

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image
image

Visuals after changes are applied

image

image

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b mjh-projects-mark-civic-opportunity-OnHold-3893 gh-pages
git pull https://github.com/mjh-projects/website.git mark-civic-opportunity-OnHold-3893

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 2, 2023
@mjh-projects mjh-projects requested review from jbubar and removed request for jbubar February 2, 2023 09:49
@bzzz-coding bzzz-coding self-requested a review February 2, 2023 21:36
@bzzz-coding
Copy link
Member

Availability: Thursday 2-4pm, Tuesday evenings.
ETA: 2/2/23 by 4pm.

bzzz-coding
bzzz-coding approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@bzzz-coding bzzz-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjh-projects Thanks for working on this issue!
I see that you have changed the status from Active to On Hold in _projects/civic-opportunity-project.md file. I have also tested in docker and can see the pages showing the On Hold status.
Great job! Also, thanks for including screenshots of the changes on the web pages!

@MattPereira MattPereira self-requested a review February 4, 2023 22:50
@MattPereira
Copy link
Contributor

ETA: 20 minutes
Availability: 8 - 10 PM Sunday - Thursday

MattPereira
MattPereira approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mjh-projects ! 👍

Your change works as intended and your screenshots are magnificent

@MattPereira MattPereira merged commit 095d9d6 into hackforla:gh-pages Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattPereira MattPereira MattPereira approved these changes

@bzzz-coding bzzz-coding bzzz-coding approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark Civic Opportunity Project as On Hold
3 participants
@mjh-projects @bzzz-coding @MattPereira