Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove alt-hero from tdm-calculator.md #3733

Merged
merged 1 commit into from
Nov 21, 2022
Merged

remove alt-hero from tdm-calculator.md #3733

merged 1 commit into from
Nov 21, 2022

Conversation

SZwerling
Copy link
Member

Fixes #3212

What changes did you make and why did you make them ?

  • I removed line 8 of tdm-calculator.md because this alt text was not being used anywhere.

  • No visual change.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b SZwerling-remove-unused-alt-hero-3212 gh-pages
git pull https://github.com/SZwerling/website.git remove-unused-alt-hero-3212

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Nov 20, 2022
@blulady blulady requested review from giroz and roslynwythe November 20, 2022 18:14
@giroz
Copy link
Member

giroz commented Nov 20, 2022

ETA: 11-21-22
Availability: 2 hours

@roslynwythe
Copy link
Member

Availability: 1-3 pm today 11/20

@roslynwythe
Copy link
Member

@SZwerling - Your update to the code change as well as your documentation look great. Thank you.

roslynwythe
roslynwythe reviewed Nov 20, 2022
View reviewed changes
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code update and documentation look great.

@roslynwythe roslynwythe reopened this Nov 20, 2022
@roslynwythe
Copy link
Member

I approve this PR but perhaps I should not have closed it, so reopened.

@patrickohh patrickohh self-requested a review November 20, 2022 23:27
@patrickohh
Copy link
Member

Review ETA: 11/20/22
Availability: 3 - 4 PM PST

patrickohh
patrickohh approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@patrickohh patrickohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SZwerling Great work! The required changes to the file have been made and documentation through the pull request has been completed correctly.

roslynwythe
roslynwythe approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, approved

@MattPereira
Copy link
Contributor

I approve this PR but perhaps I should not have closed it, so reopened.

@roslynwythe You are correct that you are not supposed to close the pull request after submitting your review.

I recommend reviewing the hfla wiki for how to review pull requests for reference as you conduct your future PR reviews.

@MattPereira MattPereira merged commit 8a19690 into hackforla:gh-pages Nov 21, 2022
giroz
giroz reviewed Nov 23, 2022
View reviewed changes
Copy link
Member

@giroz giroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! On removing the text.

MattPereira pushed a commit to MattPereira/website that referenced this pull request Nov 25, 2022
@SZwerling
remove alt-hero from tdm-calculator.md (hackforla#3733)
94574cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giroz giroz giroz left review comments

@roslynwythe roslynwythe roslynwythe approved these changes

@patrickohh patrickohh patrickohh approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused alt-hero field from tdm-calculator.md project file
6 participants
@SZwerling @giroz @roslynwythe @patrickohh @MattPereira @ExperimentsInHonesty