-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace content field remove type field in process.yml #3689
replace content field remove type field in process.yml #3689
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability Wednesday 6-9pm |
Review ETA: 11/2/22 12:30pm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, @luiderek! Thank you for taking the time to create a new PR with the corrected branch name. I had no problem with the issue link.
@luiderek it looks like you made the proper changes to the .yml file as the issue asked, and you also pushed your branch to the correct repo, but don't forget to reassign yourself as an assignee so you get the credit. 2.4 Claiming an Issue |
I believe I'm still listed as an assignee for issue #2856 itself, it's just now linked to both a closed and this pull request now. Bot magic and all. |
Oh pardon me. Then yes you did a great job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All approved!!
Fixes #2856
What changes did you make and why did you make them
For the file:
_data/internal/credits/process.yml
Oops about the bad link. Unsure if it was caused by the initial "Fixes ####", or the commit message. Opted to not include an issue code within the commit to be safe.