Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace content field remove type field in process.yml #3689

Merged

Conversation

luiderek
Copy link
Member

@luiderek luiderek commented Nov 2, 2022

Fixes #2856

What changes did you make and why did you make them

For the file: _data/internal/credits/process.yml

  • replaced the content field with content-type
  • removed the type field

Oops about the bad link. Unsure if it was caused by the initial "Fixes ####", or the commit message. Opted to not include an issue code within the commit to be safe.

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b luiderek-edit-process-yml-credits-2856 gh-pages
git pull https://github.com/luiderek/hfla-website.git edit-process-yml-credits-2856

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Nov 2, 2022
@gstemmann gstemmann self-requested a review November 2, 2022 16:47
@gstemmann
Copy link
Member

Availability Wednesday 6-9pm
ETA: November 7, 2022

@gstemmann gstemmann removed their request for review November 2, 2022 16:51
@jyaymie jyaymie self-requested a review November 2, 2022 18:45
@jyaymie
Copy link
Member

jyaymie commented Nov 2, 2022

Review ETA: 11/2/22 12:30pm
Availability: Now til 12:30pm

Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, @luiderek! Thank you for taking the time to create a new PR with the corrected branch name. I had no problem with the issue link.

@gstemmann
Copy link
Member

@luiderek it looks like you made the proper changes to the .yml file as the issue asked, and you also pushed your branch to the correct repo, but don't forget to reassign yourself as an assignee so you get the credit. 2.4 Claiming an Issue

@gstemmann gstemmann self-requested a review November 2, 2022 20:06
@luiderek
Copy link
Member Author

luiderek commented Nov 2, 2022

I believe I'm still listed as an assignee for issue #2856 itself, it's just now linked to both a closed and this pull request now. Bot magic and all.

@gstemmann
Copy link
Member

I believe I'm still listed as an assignee for issue #2856 itself, it's just now linked to both a closed and this pull request now. Bot magic and all.

Oh pardon me. Then yes you did a great job!

Copy link
Member

@gstemmann gstemmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All approved!!

@jdingeman jdingeman merged commit 4329a1b into hackforla:gh-pages Nov 3, 2022
@luiderek luiderek deleted the edit-process-yml-credits-2856 branch November 3, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from process.yml credits file
4 participants