Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed content field to content-type; removed type field #3632

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Changed content field to content-type; removed type field #3632

merged 1 commit into from
Oct 17, 2022

Conversation

Skydodle
Copy link
Member

Fixes #2843

What changes did you make and why did you make them ?

  • Changed content: icon to content-type: image, which the content-type field allows more media file options for the future updates
  • Removed type: icon, no longer needed

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Skydodle-edit-content-field-2843 gh-pages
git pull https://github.com/Skydodle/website.git edit-content-field-2843

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review labels Oct 17, 2022
@mariareeves mariareeves self-requested a review October 17, 2022 19:07
@mariareeves
Copy link
Member

ETA: 10-17-22
Availability: 2 hrs

mariareeves
mariareeves approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@mariareeves mariareeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Changes made correctly. Good job!

@jdingeman jdingeman merged commit 5174190 into hackforla:gh-pages Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariareeves mariareeves mariareeves approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from idea.yml credits file
3 participants
@Skydodle @mariareeves @jdingeman